Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default logo reference should not be absolute #119

Closed
guusdk opened this issue May 18, 2024 · 4 comments
Closed

Default logo reference should not be absolute #119

guusdk opened this issue May 18, 2024 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@guusdk
Copy link

guusdk commented May 18, 2024

Describe the bug

I'm trying to deploy xmpp-web in a context root of my webserver (eg: https://example/xmppweb).

On the login screen, I'm greeted with a broken image.

It appears that the default location of the image that is used, (when the logoUrl option is left empty) is absolute: /img/icons/android-chrome-192x192.png. This causes the breaking image, as the webapp attempts to download:

https://example/img/icons/android-chrome-192x192.png

instead of:

https://example/xmppweb/img/icons/android-chrome-192x192.png

It is easily worked-around by configuring the relative path in local.js, like this:

  logoUrl: "./img/icons/android-chrome-192x192.png",

... but it'd be nice if this would work out of the box.

Steps to reproduce

No response

Expected behavior

Without specifying a logoUrl, the image that is used by default should be loaded based on a relative, not absolute location.

Relevant log

No response

local.js configuration

No response

XMPP-web version

0.10.0

Installation

Github release archive

XMPP server(s)

Openfire

Browser(s)

Chrome

Device(s)

desktop

Other information

No response

@guusdk guusdk added the bug Something isn't working label May 18, 2024
@virtadpt
Copy link

Yes, please. This is a problem that's been keeping me from using this application.

@guusdk
Copy link
Author

guusdk commented May 18, 2024

Does the workaround that I described not work for you?

@nioc
Copy link
Owner

nioc commented May 18, 2024

Hi, yes the problem is here:
https://github.com/nioc/xmpp-web/blob/master/src%2Fcomponents%2FLogin.vue#L99

I can fix it, do you have any others issues with subfolder usage?

@guusdk
Copy link
Author

guusdk commented May 19, 2024

It is still early days, but I have not found any other of these issues yet!

@nioc nioc added this to the 0.10.1 milestone May 20, 2024
@nioc nioc self-assigned this May 20, 2024
@nioc nioc closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants