Add Service 'id' property and make 'id' property play identity role #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdodge
requested changes
Mar 9, 2018
nio/router/diagnostic.py
Outdated
| @@ -16,7 +16,7 @@ def __init__(self): | |||
|
|
|||
| self._start_time = None | |||
| self._instance_id = None | |||
| self._service_name = None | |||
There was a problem hiding this comment.
Can we provide both name and ID in most of these status/diagnostic signals? That would make it backwards compatible still and I think in many cases we would want to use the name too. Having both available would be best.
mattdodge
approved these changes
Mar 9, 2018
f1401martin
changed the title
id property and make id property play identity role
f1401martin
added
change/added
f1401martin
changed the title
id property and make id property play identity role
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.