Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View to intervals when interval is entirely outside the bounds of data results in an exception #861

Closed
cmeyer opened this issue Jun 28, 2022 · 0 comments
Closed

View to intervals when interval is entirely outside the bounds of data results in an exception #861

cmeyer opened this issue Jun 28, 2022 · 0 comments
Assignees
@gosselind1
Labels
f - displays f - line-plot good first issue good for newcomers type - bug

Comments

@cmeyer
Copy link
Collaborator

cmeyer commented Jun 28, 2022

See #513 too.

A PR should include test cases for this issue, #513, and the inside-the-data interval use cases.
gosselind1 added a commit to gosselind1/nionswift that referenced this issue Jun 30, 2022
@gosselind1
Fixed nion-software#861
6b2b81a 
Refactored LinePlotCanvasItem.__view_to_intervals
Fixed bugs relating to view area calculations
@cmeyer cmeyer closed this as completed in 7d49523 Jun 30, 2022
gosselind1 added a commit to gosselind1/nionswift that referenced this issue Aug 6, 2022
@gosselind1
Fix nion-software#861. Fix view-to-intervals with intervals entirely …
cc8bab6 
…outside data bounds. Add tests for inside/outside cases.

Test added for a bug that occurs when zoooming in with an interval on the right side of a lineplot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gosselind1 gosselind1

Labels
f - displays f - line-plot good first issue good for newcomers type - bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmeyer @gosselind1