Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game turns all button prompts to "0" when FallbackToEnglishKeyIcons is enabled #121

Closed
plrusek opened this issue Feb 17, 2022 · 16 comments
Closed

Comments

@plrusek
Copy link

plrusek commented Feb 17, 2022

The option is also enabled by default.

Turned on:
image

Turned off:
image

@emoose
Copy link
Collaborator

emoose commented Feb 17, 2022

Hmm, can you post what system language you use and keyboard locale? Also, do you have any English language/locale installed on your system at all?

From looks of it, your game language is English too?

We're trying to look into this at #64 but haven't had any luck yet, hopefully will be able to figure something soon.

@plrusek
Copy link
Author

plrusek commented Feb 17, 2022

My game language is English, my system language is also English but keyboard locale is Polish, as well as the current language for non-Unicode programs, according to Windows' Region settings (referred to as system locale).
image

@emoose
Copy link
Collaborator

emoose commented Feb 17, 2022

Interesting, didn't think game had support for key icons with Polish layout, maybe the invisible icons issue only happens with Russian KB for some reason.

Do you know if you have English keyboard locale installed on your system at all? The 0 key issue might be happening when there's no English layout installed, not totally sure about that yet though.

@plrusek
Copy link
Author

plrusek commented Feb 17, 2022

Only Polish keyboard locale.

@nipkownix
Copy link
Owner

Can you test this build? Should fix the issue.
re4_tweaks_keyicon-fallback-fix_2022-02-17_220730.zip

@bursoft-git
Copy link

Hi! Thank you to your awesome work!
I hawe this issue too/
My system is Win11, Russian language, RE4HD 1.1 with re4_tweaks 1.7.7.6
When i use English keyboard layout, game shows D in fast press QTE, as expected

bio4_2022_08_11_20_19_46_021

But when i switch to Russian layout, game shows 0

bio4_2022_08_11_20_20_39_508

@nipkownix
Copy link
Owner

Could you please open dinput8.dll, set "VerboseLog" to true, re-open the game and then upload your dinput8.log here?

@bursoft-git
Copy link

Could you please open dinput8.dll, set "VerboseLog" to true, re-open the game and then upload your dinput8.log here?

Yes, of course, here it is
dinput8.log

@nipkownix
Copy link
Owner

@bursoft-git Does this only happen with QTEs? Are other prompts fine? (enter door, save game, etc)

@bursoft-git
Copy link

@bursoft-git Does this only happen with QTEs? Are other prompts fine? (enter door, save game, etc)

Save game, open doors, and other actions with E button are OK
I do not check other QTEs, this one first i found
Later i check different QTEs with A/D buttons

@nipkownix
Copy link
Owner

@emoose Seems to be the same bug you fixed in the game with FallbackToEnglishKeyIcons, but this time it affects our input::PopulateKeymap(). Not sure how to fix that, honestly.

@nipkownix
Copy link
Owner

nipkownix commented Aug 15, 2022

Ah, I think this may be a different issue after all.
KeyMap_getDIK(pConfig->sQTE_key_1) returns garbage if the lang is Russian and the current QTE key is the default one (D), because our keymap expects the russian ver instead. (В).

@bursoft-git, could you try to open the F1 menu and rebind the QTE keys? this should fix it.

@bursoft-git
Copy link

bursoft-git commented Aug 15, 2022

i rebind keys

[22:44:48] [t 12376] | QTE_key_1                      |               В |

and now game shows "correct" D button with Russian layout, and 0 with English)

@nipkownix
Copy link
Owner

Could you check this build, please?
dinput8.zip

@bursoft-git
Copy link

Could you check this build, please? dinput8.zip

now game shows correct D button in both Russian and English layout!
thanks!

@nipkownix
Copy link
Owner

No problem ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants