Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Gamecube merchant deaths #238

Open
JackSound01 opened this issue Jul 1, 2022 · 6 comments
Open

[Feature Request] Gamecube merchant deaths #238

JackSound01 opened this issue Jul 1, 2022 · 6 comments

Comments

@JackSound01
Copy link

JackSound01 commented Jul 1, 2022

Describe the feature you'd like to see added

I don't know if you could add the deaths of the merchant present in the gamecube version, since they are much better..

@JackSound01 JackSound01 changed the title Gamecube peddler deaths Gamecube merchant deaths Jul 1, 2022
@JackSound01 JackSound01 changed the title Gamecube merchant deaths [Feature Request] Gamecube merchant deaths Jul 1, 2022
@linkthehylian
Copy link

linkthehylian commented Jul 1, 2022

I'm not really sure what this means. Are his deaths not the same in every version?

@JackSound01
Copy link
Author

I'm not really sure what this means. Are his deaths not the same in every version?

Nop, look at this video at 10:15: https://www.youtube.com/watch?v=VV6jV-XGL_8

@linkthehylian
Copy link

linkthehylian commented Jul 2, 2022

Nop, look at this video at 10:15: https://www.youtube.com/watch?v=VV6jV-XGL_8

Ooh, interesting! This is something I never knew about until now.

It seems to be weapon exclusive though. I suppose it would definitely be possible to change the death animation based on the weapon that's being used.

@LethalPlacebo
Copy link

LethalPlacebo commented Jul 2, 2022

I never knew about this either, incredible! It seems that for the GC version he uses the same death animations as the Ganado, he just goes down in 1 hit, whereas in all later versions he has the same unique death animation where he falls to his knees.

@emoose
Copy link
Collaborator

emoose commented Jul 3, 2022

Huh interesting, will have to try comparing code against GC ver (for those that also want to look into it, seems em18 is the class handling Merchant)

Would be appreciated if anyone is able to check that GC debug also has these anims, since that's what I'm comparing against atm.

@linkthehylian
Copy link

Finally had some time to test all of his deaths.

Broken Butterfly

Dolphin.Emulator.2022.08.21.-.15.58.35.01.mp4

Shotgun

Dolphin.Emulator.2022.08.21.-.16.00.49.02.mp4

Mine Thrower

Dolphin.Emulator.2022.08.21.-.16.02.08.03.mp4

Infinite Rocket Launcher

Dolphin.Emulator.2022.08.21.-.16.03.11.04.mp4

Rifle (semi-auto)

Dolphin.Emulator.2022.08.21.-.16.04.37.05.mp4

I wasn't able to test a hand grenade since I don't have one. But I'd like to believe the animation exists.

Everything here seems pretty identical to the Gamecube release. Hope it helps! @emoose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants