fix: implement @jdkent's suggestion for ICA-AROMA version retrieval […

…skip ci]
nipreps · Sep 11, 2019 · 7042c8d · 7042c8d
1 parent 7a1fa11
commit 7042c8d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -112,7 +112,8 @@ RUN mkdir -p /opt/ICA-AROMA && \
   curl -sSL "https://github.com/maartenmennes/ICA-AROMA/archive/v0.4.4-beta.tar.gz" \
   | tar -xzC /opt/ICA-AROMA --strip-components 1 && \
   chmod +x /opt/ICA-AROMA/ICA_AROMA.py
-ENV PATH=/opt/ICA-AROMA:$PATH
+ENV PATH="/opt/ICA-AROMA:$PATH" \
+    AROMA_VERSION="0.4.4-beta"
 
 # Installing and setting up miniconda
 RUN curl -sSLO https://repo.continuum.io/miniconda/Miniconda3-4.5.11-Linux-x86_64.sh && \

diff --git a/fmriprep/workflows/bold/confounds.py b/fmriprep/workflows/bold/confounds.py
@@ -9,6 +9,7 @@
 .. autofunction:: init_ica_aroma_wf
 
 """
+from os import getenv
 from nipype.pipeline import engine as pe
 from nipype.interfaces import utility as niu, fsl
 from nipype.algorithms import confounds as nac
@@ -694,7 +695,7 @@ def _getusans_func(image, thresh):
         TSV2JSON(index_column='IC', output=None, enforce_case=True,
                  additional_metadata={'Method': {
                                       'Name': 'ICA-AROMA',
-                                      'Version': '0.3-beta'}}),
+                                      'Version': getenv('AROMA_VERSION', 'n/a')}}),
         name='ica_aroma_metadata_fmt')
 
     ds_report_ica_aroma = pe.Node(