Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip SDC workflows off of fMRIPrep #1653

Closed
oesteban opened this issue May 28, 2019 · 6 comments
Closed

Strip SDC workflows off of fMRIPrep #1653

oesteban opened this issue May 28, 2019 · 6 comments
Assignees
Labels
effort: high Estimated high effort task fieldmaps impact: high Estimated high impact task
Milestone

Comments

@oesteban
Copy link
Member

SDC workflows should not impose the full fmriprep as a dependency.

This will indirectly make it easier to address #1469, and potentially create a small CLI to allow running SDC directly on prescribed inputs (ie., after preprocessing, not BIDS-compliant). That would allow a more agile evaluation of SDC (cc @mattcieslak).

@effigies
Copy link
Member

Niworkflows is not super light:

REQUIRES = [
    'jinja2',
    'matplotlib>=2.2.0',
    'nilearn>=0.2.6,!=0.5.0,!=0.5.1',
    'nipype>=1.1.6',
    'packaging',
    'pandas',
    'pybids>=0.7,<0.8',
    'PyYAML',
    'scikit-image',
    'scipy',
    'seaborn',
    'svgutils',
    'templateflow<0.2.0a0,>=0.1.7',
]

It might be worth breaking these things into extras. A lot of that could be bundled into a reports extra.

@oesteban oesteban added this to To do in Fieldmaps Refactor May 28, 2019
@oesteban
Copy link
Member Author

I agree. But to keep things in scope I'd propose to first move to NIWorkflows (which is lighter than fmriprep) and open an issue there trying to modularize that beast.

If isolation of SDC workflows is well designed, it should be trivial to move it wherever we like (e.g., as and independent niflow) and strip it off of niworkflows.

WDYT?

@oesteban
Copy link
Member Author

oesteban commented May 28, 2019

On the other hand, providing some kind of independent workflow would make testing and benchmarking a lot more agile (I'm thinking of your use-case, @mattcieslak)

EDIT: another plus is that we can add collaborators to the project without them having access to the whole niworkflows.

@oesteban oesteban changed the title Move SDC workflows to NIWorkflows Strip SDC workflows off of fMRIPrep May 28, 2019
@effigies
Copy link
Member

Sure.

@mattcieslak
Copy link

Are you proposing a new repository just for SDC workflows or adding a module to niworkflows? I've had some difficulty with niworkflows as a dependency of qsiprep because it changes so frequently. It might be nice to have a stand-alone set of SDC workflows that will be mostly frozen after we optimize the fieldmapless method. I'd defer this decision to you guys though

@oesteban
Copy link
Member Author

Yeah, after reflecting a bit I'm convinced now that an independent repo will be best.

oesteban added a commit to oesteban/niworkflows that referenced this issue Jun 5, 2019
@oesteban oesteban added this to the 1.4.2 milestone Jul 9, 2019
@oesteban oesteban modified the milestones: 1.4.2, 1.4.3 Jul 11, 2019
@oesteban oesteban added effort: high Estimated high effort task impact: high Estimated high impact task labels Jul 15, 2019
@oesteban oesteban added this to To do in pipelines via automation Jul 15, 2019
@oesteban oesteban moved this from To do to Development backlog in pipelines Jul 15, 2019
@oesteban oesteban moved this from Development backlog to Next week's targets in pipelines Jul 15, 2019
@oesteban oesteban self-assigned this Jul 15, 2019
@oesteban oesteban moved this from Next week's targets to Awaiting review in pipelines Jul 21, 2019
pipelines automation moved this from Awaiting review to Done Jul 23, 2019
@oesteban oesteban removed this from Done in pipelines Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: high Estimated high effort task fieldmaps impact: high Estimated high impact task
Projects
No open projects
Development

No branches or pull requests

3 participants