[FIX] Derivatives datasink handling of compression #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Apr 27, 2018
fmriprep/interfaces/bids.py
Outdated
| src_isgz = src.endswith('.gz') | ||
| dst_isgz = dst.endswith('.gz') | ||
| if src_isgz == dst_isgz: | ||
| copyfile(src, dst, use_hardlink=True) |
There was a problem hiding this comment.
Need copy=True in there, otherwise we might end up with symlinks.
effigies
approved these changes
Apr 27, 2018
|
Looks good, thanks. @oesteban do we want to add any sanity checks, such as making sure that all image files in the output can at least be Actually, maybe we should add |
|
Adding I think the |
|
I've opened #1078. I'll merge this in since it is quite urgent. |
oesteban
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not fully tested - adapted from @effigies #1075 (comment)