Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Resume external nipype dependency #1133

Merged
merged 7 commits into from
May 31, 2018

Conversation

effigies
Copy link
Member

@effigies effigies commented May 16, 2018

Purges niworkflows.nipype in favor of nipype.

Pins nipreps/niworkflows#241.


Original text:

This is just to validate nipreps/niworkflows#238. Should be a functionally inert refactor, so can wait for the next niworkflows release to actually update the pin.

@effigies effigies force-pushed the pin/niworkflows branch 5 times, most recently from ae0ac1d to 2bdf319 Compare May 17, 2018 00:38
@effigies
Copy link
Member Author

@oesteban There's another ICA-AROMA bug popping up. I think you've been paying closer attention to these than I have... Could you take a quick look to see if it's an old problem reemerging or something I'm introducing?

@oesteban
Copy link
Member

oesteban commented May 17, 2018

The symptoms indicate a regression of AROMA writing in /opt/ICA-AROMA/:

Step 1) MELODIC
  - The existing/specified MELODIC directory will be used.
Standard error:
Traceback (most recent call last):
  File "/opt/ICA-AROMA/ICA_AROMA.py", line 193, in <module>
    aromafunc.runICA(fslDir, inFile, outDir, melDir, mask, dim, TR)
  File "/opt/ICA-AROMA/ICA_AROMA_functions.py", line 55, in runICA
    os.symlink(melDirIn, melDir)
FileExistsError: [Errno 17] File exists: '/scratch/fmriprep_wf/single_subject_01_wf/func_preproc_task_mixedgamblestask_run_01_wf/ica_aroma_wf/melodic' -> 'out/melodic.ica'
Return code: 1

I bet that out/melodic.ica is being linked under /opt/ICA-AROMA. Maybe the new report capable interfaces are not taking in the rewrite of the input?

EDIT: the previous error not finding an input would be caused by Nipype looking for the output under the node's folder, while they are under /opt/ICA-AROMA.

@oesteban
Copy link
Member

Oh yeah, look at the command line, the output arg is just -o out.

@effigies
Copy link
Member Author

Gotcha. Merging nipype/master in. Didn't realize I hadn't.

@effigies effigies force-pushed the pin/niworkflows branch 2 times, most recently from cf31881 to 1e940ef Compare May 17, 2018 17:05
@effigies effigies changed the title [NOMERGE] PIN: effigies/niworkflows feature branch RF: Resume external nipype dependency May 29, 2018
@effigies effigies changed the title RF: Resume external nipype dependency [WIP] RF: Resume external nipype dependency May 29, 2018
@effigies effigies changed the title [WIP] RF: Resume external nipype dependency RF: Resume external nipype dependency May 31, 2018
@effigies effigies merged commit 5747a6d into nipreps:master May 31, 2018
@effigies effigies deleted the pin/niworkflows branch May 31, 2018 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants