Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Ensure encoding when reading boilerplate #1322

Merged
merged 1 commit into from Oct 17, 2018

Conversation

alioco
Copy link
Contributor

@alioco alioco commented Oct 15, 2018

Changes proposed in this pull request

Fix for error in generate_report function encountered when running singularity image of fmriprep version 1.1.8 on a cluster, with singularity version 2.6.0 raised in issue #1313.

Fixes #1313.

Documentation that should be reviewed

The flag encoding='UTF-8’ was added for all read_text and write_text functions.

@welcome
Copy link

welcome bot commented Oct 15, 2018

Thanks for opening this pull request! We have detected this is the first time for you to contribute to fMRIPrep. Please check out our contributing guidelines.
We invite you to list yourself as a fMRIPrep contributor, so if your name is not already mentioned, please modify the .zenodo.json file with your data right above Russ' entry. Example:

{
   "name": "Contributor, New FMRIPrep",
   "affiliation": "Department of fMRI prep'ing, Open Science Made-Up University",
   "orcid": "<your id>"
},
{
   "name": "Poldrack, Russell A.",
   "affiliation": "Department of Psychology, Stanford University",
   "orcid": "0000-0001-6755-0259"
},

Of course, if you want to opt-out this time there is no problem at all with adding your name later. You will be always welcome to add it in the future whenever you feel it should be listed.

@oesteban
Copy link
Member

Hi @alioco, are you planning on adding your name to the zenodo file or you'd rather opt out this time?

I'll merge as soon as I have an answer.

Thanks a lot for your contribution!

@alioco
Copy link
Contributor Author

alioco commented Oct 17, 2018

@oesteban I'll opt out at this time, thank you!

@oesteban oesteban changed the title [FIX] update reports.py for Singularity image [FIX] Ensure encoding when reading boilerplate Oct 17, 2018
@oesteban oesteban merged commit fbe25f0 into nipreps:master Oct 17, 2018
@effigies effigies added this to the 1.2.0 milestone Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in generate_report function
3 participants