Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Support 4D SBRefs when generating the bold reference #1581

Merged
merged 6 commits into from
Apr 17, 2019

Conversation

oesteban
Copy link
Member

Part of #1511. Addresses #1579 and #1463.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Assume you have a test dataset you're checking this on?

@oesteban
Copy link
Member Author

oesteban commented Apr 11, 2019 via email

@effigies
Copy link
Member

I've pushed this as docker/4dsbref, so when the build finishes we can build a singularity image from poldracklab/fmriprep:4dsbref.

@effigies
Copy link
Member

@IanEisenberg Are you able to build a new singularity image from a Docker image? Try:

singularity build fmriprep_4dsbref.simg docker://podracklab/fmriprep:4dsbref

I don't know if other options are needed on your environment, but if you use other options usually, go ahead.

@oesteban
Copy link
Member Author

I just confirmed this patch works out.

@oesteban oesteban merged commit ba4ebeb into nipreps:master Apr 17, 2019
@oesteban oesteban deleted the fix/issue-1579 branch April 17, 2019 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants