CI: Build docs outside of container

[effigies]

Changes proposed in this pull request

This should speed up builds somewhat by avoiding using the container in the documentation build and avoiding the container build in doc(s)/* branches.

Documentation that should be reviewed

[oesteban]

I suspect we also want to update the Makefile to treat warnings as errors.

This is an incredible optimization 👍

[effigies]

Locally I'm getting this failure:

Warning, treated as error:
/Users/markiewicz/Projects/crn/fmriprep/venv/lib/python3.6/site-packages/fmriprep/workflows/base.py:docstring of fmriprep.workflows.base.init_fmriprep_wf:7:Exception occurred in plotting index-1
 from /Users/markiewicz/Projects/crn/fmriprep/docs/api/index.rst:
Traceback (most recent call last):
  File "/Users/markiewicz/Projects/crn/fmriprep/venv/lib/python3.6/site-packages/nipype/sphinxext/plot_workflow.py", line 485, in run_code
    exec(code, ns)
  File "<string>", line 38, in <module>
  File "/Users/markiewicz/Projects/crn/fmriprep/venv/lib/python3.6/site-packages/fmriprep/workflows/base.py", line 218, in init_fmriprep_wf
    err_on_aroma_warn=err_on_aroma_warn,
  File "/Users/markiewicz/Projects/crn/fmriprep/venv/lib/python3.6/site-packages/fmriprep/workflows/base.py", line 462, in init_single_subject_wf
    skull_strip_template=skull_strip_template,
TypeError: init_anat_preproc_wf() got an unexpected keyword argument 'output_spaces'
make: *** [html] Error 2

Looks like what @markushs is seeing over in #1603.

[oesteban]

smriprep version?

[effigies]

smriprep version?

v0.1.1. Whatever builds with pip install ".[doc]".

[effigies]

It's very unclear to me what LINKS_REQUIRES is supposed to be doing. Does anything respect it?

[effigies]

@oesteban This should allow us to install purely with pip install ., as pip will parse this first to make sure it has the build dependencies.

pip 18.1 allows us to use a dependency that looks like "package @ URL", so we can handle all dependencies directly in install_requires.

[effigies]

Relevant discussion: https://stackoverflow.com/a/53412651

Possibly the reason this is failing for me is that pip removed dependency_links in version 19.

[effigies]

Hmm. Looks like you can't actually set a minimum version on pip in this way. pypa/pip#4145

So this would mean we need to prepare for users with old pip, which is likely on most HPCs.

[oesteban]

smriprep 0.2.0 has just posted. I would not spend a lot of time fighting pip.

[oesteban]

this was potentially working. please note that comma breaking up the string concatenation.