ENH: Reduce BSplineFieldmap memory usage #1609
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Was looking at the
maths.pyx
thing to see about splitting it out into its own package. Noticed someget_data()
uses inBSplineFieldmap
.get_data()
is supposed to be being deprecated any day now... and the two calls to it are sub-optimal.The first can just be replaced by the image shape, which is just read from the header and doesn't require loading the data.
The second can use
get_fdata
, and if we usecaching='unchanged'
, then it won't store a copy of the array internally, so it can get garbage-collected after filling_data
.I don't expect this is going to have a significant effect, but just while I was there.
Documentation that should be reviewed