Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Confound enhancement documentation #1625

Merged
merged 3 commits into from
May 10, 2019
Merged

Conversation

rciric
Copy link
Contributor

@rciric rciric commented May 9, 2019

Changes proposed in this pull request

Documentation that should be reviewed

  • outputs.rst is extended to include more complete descriptions of the new confounds functionality.

@rciric rciric changed the title Confound enhancement documentation [DOC] Confound enhancement documentation May 9, 2019
@effigies effigies added this to the 1.4.0 milestone May 9, 2019
@oesteban oesteban changed the title [DOC] Confound enhancement documentation DOC: Confound enhancement documentation May 9, 2019
Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatted list, left some other comments

docs/outputs.rst Outdated Show resolved Hide resolved
docs/outputs.rst Outdated Show resolved Hide resolved
docs/outputs.rst Outdated Show resolved Hide resolved
docs/outputs.rst Outdated Show resolved Hide resolved
docs/outputs.rst Outdated Show resolved Hide resolved
docs/outputs.rst Outdated Show resolved Hide resolved
docs/outputs.rst Outdated Show resolved Hide resolved
docs/outputs.rst Outdated Show resolved Hide resolved
docs/outputs.rst Outdated Show resolved Hide resolved
docs/outputs.rst Outdated Show resolved Hide resolved
@@ -161,13 +161,18 @@ def init_bold_confs_wf(
in T1w space, after their projection to the native space of each
functional run (using the inverse BOLD-to-T1w transformation). Components
are also calculated separately within the WM and CSF masks.
For each CompCor decomposition, the :math:`k` components with the largest singular
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about this. I did not think it was on the boilerplate. Reverting...

Suggested change
For each CompCor decomposition, the :math:`k` components with the largest singular
For each CompCor decomposition, the k components with the largest singular

@oesteban oesteban merged commit 6aafca6 into nipreps:master May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Improve descriptions of new confounds model
3 participants