-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Confound enhancement documentation #1625
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rciric
changed the title
Confound enhancement documentation
[DOC] Confound enhancement documentation
May 9, 2019
oesteban
changed the title
[DOC] Confound enhancement documentation
DOC: Confound enhancement documentation
May 9, 2019
oesteban
reviewed
May 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatted list, left some other comments
oesteban
reviewed
May 10, 2019
@@ -161,13 +161,18 @@ def init_bold_confs_wf( | |||
in T1w space, after their projection to the native space of each | |||
functional run (using the inverse BOLD-to-T1w transformation). Components | |||
are also calculated separately within the WM and CSF masks. | |||
For each CompCor decomposition, the :math:`k` components with the largest singular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about this. I did not think it was on the boilerplate. Reverting...
Suggested change
For each CompCor decomposition, the :math:`k` components with the largest singular | |
For each CompCor decomposition, the k components with the largest singular |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Documentation that should be reviewed
outputs.rst
is extended to include more complete descriptions of the new confounds functionality.