Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Move regression tests of EPI masks over to Niworkflows #1716

Merged
merged 6 commits into from
Jul 26, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
69 changes: 3 additions & 66 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -176,42 +176,6 @@ jobs:
- /tmp/data
- /tmp/ds005/derivatives/freesurfer

get_regression_data:
machine:
# Ubuntu 14.04 with Docker 17.10.0-ce
image: circleci/classic:201711-01
working_directory: /home/circleci/data
steps:
- restore_cache:
keys:
- regression-v3-{{ .Revision }}
- regression-v3-
- run:
name: Get truncated BOLD series
command: |
mkdir -p /tmp/data
if [[ ! -d /tmp/data/fmriprep_bold_truncated ]]; then
wget --retry-connrefused --waitretry=5 --read-timeout=20 --timeout=15 -t 0 -q \
-O fmriprep_bold_truncated.tar.gz "https://osf.io/286yr/download"
tar xvzf fmriprep_bold_truncated.tar.gz -C /tmp/data/
else
echo "Truncated BOLD series were cached"
fi
- run:
name: Get pre-computed masks
command: |
if [[ ! -d /tmp/data/fmriprep_bold_mask ]]; then
wget --retry-connrefused --waitretry=5 --read-timeout=20 --timeout=15 -t 0 -q \
-O fmriprep_bold_mask.tar.gz "https://osf.io/s4f7b/download"
tar xvzf fmriprep_bold_mask.tar.gz -C /tmp/data/
else
echo "Pre-computed masks were cached"
fi
- save_cache:
key: regression-v3-{{ .Revision }}-{{ epoch }}
paths:
- /tmp/data

test_pytest:
machine:
image: circleci/classic:201711-01
Expand All @@ -237,9 +201,6 @@ jobs:
- restore_cache:
keys:
- docker-v3-{{ .Branch }}-{{ .Revision }}
- restore_cache:
keys:
- regression-v3-{{ .Revision }}
- run:
name: Load Docker image layer cache
no_output_timeout: 30m
Expand All @@ -255,21 +216,10 @@ jobs:
name: Run fMRIPrep tests
no_output_timeout: 2h
command: |
mkdir /tmp/data/reports && \
docker run -ti --rm=false \
-v /tmp/data:/tmp/data \
-e FMRIPREP_REGRESSION_SOURCE=/tmp/data/fmriprep_bold_truncated \
-e FMRIPREP_REGRESSION_TARGETS=/tmp/data/fmriprep_bold_mask \
-e FMRIPREP_REGRESSION_REPORTS=/tmp/data/reports \
--entrypoint="py.test" poldracklab/fmriprep:latest \
/src/fmriprep/ \
-svx --doctest-modules --ignore=/src/fmriprep/docs --ignore=setup.py
- run:
name: Package new masks
no_output_timeout: 10m
working_directory: /tmp/data/reports
command: |
tar cfz fmriprep_bold_mask.tar.gz fmriprep_bold_mask/*/*.nii.gz
--entrypoint="pytest" poldracklab/fmriprep:latest \
/src/fmriprep/fmriprep -svx --doctest-modules

- run:
name: Test fmriprep-wrapper (Python 2)
command: |
Expand Down Expand Up @@ -953,18 +903,6 @@ workflows:
tags:
only: /.*/

- get_regression_data:
filters:
branches:
ignore:
- /docs?\/.*/
- /ds005\/.*/
- /ds054\/.*/
- /ds210\/.*/
- /docker\/.*/
tags:
only: /.*/

- build_docs:
filters:
branches:
Expand All @@ -989,7 +927,6 @@ workflows:
- test_pytest:
requires:
- build
- get_regression_data
filters:
branches:
ignore:
Expand Down
20 changes: 0 additions & 20 deletions fmriprep/data/epi_atlasbased_brainmask.json

This file was deleted.

21 changes: 0 additions & 21 deletions fmriprep/data/epi_registration_settings.json

This file was deleted.

96 changes: 0 additions & 96 deletions fmriprep/workflows/bold/tests/test_util.py

This file was deleted.

2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ classifiers =
[options]
python_requires = >=3.5
install_requires =
niworkflows ~= 0.10.1
niworkflows ~= 0.10.2
smriprep ~= 0.3.1
templateflow ~= 0.4.1
nibabel >=2.2.1
Expand Down