FIX: Ignore sourcedata and derivatives when fetching data #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yarikoptic Would you care to give this branch a try? |
|
oh... I run fmriprep as released in a container. would take me a bit to do otherwise. if you have such environment ready, could you please just try running that script (removing singularity shimming) I provided in #1787 -- it should be quite straightforward |
|
If you use fmriprep-docker <all> <my> <usual> <args> -f /data/projects/fmriprep/fmriprep(Note that you need to target the Python source directory, not the repository root.) |
|
(I'll give your script a try, though.) |
that is neat! haven't used |
effigies
force-pushed
the
fix/ignore_sourcedata_etc
branch
from
0a26f17
to
7081a7c
Compare
|
Updated script to: > cat replicate-fmriprepkaboom.sh
#!/bin/bash
set -eu
datalad install ///labs/haxby/life
datalad get life/sub-rid000001 # one subject to start with
export FS_LICENSE=/Users/markiewicz/Documents/freesurfer_license.txt
mkdir -p derivatives/{work,fmriprep-1.5.0}
# manual execution to ease troubleshooting
# --skip-bids-validation since we did not get/process all the subjects, and
# https://github.com/bids-standard/bids-validator/issues/769 still scares me a lot ;)
fmriprep-docker life derivatives/fmriprep-1.5.0/ participant --skip-bids-validation \
--participant-label rid000001 -w derivatives/work \
--notrack --skull-strip-fixed-seed \
--ignore slicetiming --fs-license-file="$FS_LICENSE" \
--bold2t1w-dof 9 --output-space fsaverage5 T1w \
--n_cpus 2 --omp-nthreads 1 $@To get to the error, I ran: > bash replicate-fmriprepkaboom.sh --anat-onlyProducing (click to expand)Running with > bash replicate-fmriprepkaboom.sh --anat-only -f /Users/markiewicz/Projects/crn/fmriprep/fmriprepContinues past that point. So I'll go ahead and merge this once tests pass. @oesteban A note that rerunning with the fix and a working directory that has a crashfile in it produced Deleting the working directory resolved it. fMRIPrep reports using Nipype 1.2.2. |
|
so, the fix came without a test to solidify correct behavior... I guess it might come back to bite us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Closes #1787.
Documentation that should be reviewed