Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use recent Python image to build packages #1790

Merged
merged 1 commit into from Sep 25, 2019

Conversation

effigies
Copy link
Member

Changes proposed in this pull request

Switches to circleci/python:3.7.4 for building packages on, as this should have a long lifetime before we need to upgrade it.

The latest twine breaks Python 3.5 but still installs on it, so our current strategy fails. We could pin an older twine, but there doesn't seem much value.

@oesteban I see we're still using manylinux to build wheels. I believe we no longer need that?

Documentation that should be reviewed

@effigies effigies force-pushed the ci/upgrade_package_build_env branch 2 times, most recently from 98ec9a2 to f0d1e0e Compare September 25, 2019 16:03
@effigies effigies merged commit cc49139 into nipreps:master Sep 25, 2019
@effigies effigies deleted the ci/upgrade_package_build_env branch September 25, 2019 16:39
@oesteban
Copy link
Member

@oesteban I see we're still using manylinux to build wheels. I believe we no longer need that?

Probably not after this change 👍

@effigies
Copy link
Member Author

I looked, and it looks like we still have a cython extension. For some reason I thought that had gone with sdcflows.

@oesteban
Copy link
Member

mmm yeah, that should be gone.

@effigies
Copy link
Member Author

Okay. I'll open a PR to kill it shortly.

oesteban added a commit to oesteban/mriqc that referenced this pull request Sep 25, 2019
Similarly to nipreps/fmriprep#1790, we are changing to the Python
3.7+ docker image to test and deploy the Pypi package since twine has
stopped support for python <3.6 since their latest relase 2.0.
oesteban added a commit to oesteban/mriqc that referenced this pull request Sep 25, 2019
Similarly to nipreps/fmriprep#1790, we are changing to the Python
3.7+ docker image to test and deploy the Pypi package since twine has
stopped support for python <3.6 since their latest relase 2.0.
oesteban added a commit to oesteban/mriqc that referenced this pull request Sep 25, 2019
Similarly to nipreps/fmriprep#1790, we are changing to the Python
3.7+ docker image to test and deploy the Pypi package since twine has
stopped support for python <3.6 since their latest relase 2.0.
oesteban added a commit to oesteban/mriqc that referenced this pull request Sep 25, 2019
Similarly to nipreps/fmriprep#1790, we are changing to the Python
3.7+ docker image to test and deploy the Pypi package since twine has
stopped support for python <3.6 since their latest relase 2.0.
oesteban added a commit to oesteban/mriqc that referenced this pull request Sep 25, 2019
Similarly to nipreps/fmriprep#1790, we are changing to the Python
3.7+ docker image to test and deploy the Pypi package since twine has
stopped support for python <3.6 since their latest relase 2.0.
oesteban added a commit to oesteban/mriqc that referenced this pull request Sep 25, 2019
Similarly to nipreps/fmriprep#1790, we are changing to the Python
3.7+ docker image to test and deploy the Pypi package since twine has
stopped support for python <3.6 since their latest relase 2.0.
oesteban added a commit to oesteban/mriqc that referenced this pull request Sep 25, 2019
Similarly to nipreps/fmriprep#1790, we are changing to the Python
3.7+ docker image to test and deploy the Pypi package since twine has
stopped support for python <3.6 since their latest relase 2.0.
oesteban added a commit to oesteban/mriqc that referenced this pull request Sep 25, 2019
Similarly to nipreps/fmriprep#1790, we are changing to the Python
3.7+ docker image to test and deploy the Pypi package since twine has
stopped support for python <3.6 since their latest relase 2.0.
oesteban added a commit to oesteban/mriqc that referenced this pull request Sep 25, 2019
Similarly to nipreps/fmriprep#1790, we are changing to the Python
3.7+ docker image to test and deploy the Pypi package since twine has
stopped support for python <3.6 since their latest relase 2.0.
oesteban added a commit to oesteban/mriqc that referenced this pull request Sep 25, 2019
Similarly to nipreps/fmriprep#1790, we are changing to the Python
3.7+ docker image to test and deploy the Pypi package since twine has
stopped support for python <3.6 since their latest relase 2.0.
oesteban added a commit to oesteban/mriqc that referenced this pull request Sep 25, 2019
Similarly to nipreps/fmriprep#1790, we are changing to the Python
3.7+ docker image to test and deploy the Pypi package since twine has
stopped support for python <3.6 since their latest relase 2.0.
NPann pushed a commit to NPann/mriqc that referenced this pull request Dec 12, 2019
Similarly to nipreps/fmriprep#1790, we are changing to the Python
3.7+ docker image to test and deploy the Pypi package since twine has
stopped support for python <3.6 since their latest relase 2.0.
NPann pushed a commit to NPann/mriqc that referenced this pull request Dec 12, 2019
Similarly to nipreps/fmriprep#1790, we are changing to the Python
3.7+ docker image to test and deploy the Pypi package since twine has
stopped support for python <3.6 since their latest relase 2.0.
oesteban added a commit to nipreps/nireports that referenced this pull request Feb 28, 2023
Similarly to nipreps/fmriprep#1790, we are changing to the Python
3.7+ docker image to test and deploy the Pypi package since twine has
stopped support for python <3.6 since their latest relase 2.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants