Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Purge Cython and depend on SDCflows #1792

Merged
merged 5 commits into from Oct 15, 2019

Conversation

effigies
Copy link
Member

Changes proposed in this pull request

We've moved all the fieldmap tools into sdcflows, so we don't need the Cython extensions in fMRIPrep. This removes maths.pyx and all code that depends on it, and updates fmriprep.interfaces.fmap to import its contents from sdcflows.interfaces.fmap.

Cython and numpy have been removed from the build requirements, and the wheel built on CircleCI will be pure Python, so we can drop manylinux.

Documentation that should be reviewed

@effigies
Copy link
Member Author

@oesteban I don't know what's up with the ds005 and ds210 errors. Looks like some other nipype regression.

@oesteban
Copy link
Member

I'm pretty positive those errors will go away if we clean the cache. We should use this as an opportunity to debug nipy/nipype#3014 (this is an instance of this issue). Can you think of a way to retrieve Circle's cache and take it to a controlled environment?

@effigies
Copy link
Member Author

effigies commented Sep 26, 2019

Just create a job that loads the cache and saves it as an artifact? Could tarball it for easy download.

@oesteban
Copy link
Member

Just create a job that loads the cache and saves it as an artifact? Could tarball it for easy download.

I think Circle tells you the identifier of the cache it found and retrieved. We may want to have a build that finds a cache identifier on the commit message and tarballs the cache. Nothing otherwise. Could be helpful in the future. WDYT?

Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed one file that wasn't necessary anymore and updated the sdcflows pin.

@oesteban oesteban merged commit 2c0a8b3 into nipreps:master Oct 15, 2019
@effigies effigies deleted the maint/build_deps branch August 24, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants