FIX: Error during version check trying to access read-only file systems #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank your for raising your pull request. Some of the fMRIPRep maintainers will review your changes as soon as time permits. ## PR Review
*Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide*
- [ ] As the reviewer I confirm that there are no conflicts of interest for me to review this work.
Please check what applies in the following aspects of the PR:
#### Code documentation
- [ ] New functions and modules are documented following the guidelines.
- [ ] Existing code required amendments in documentation and has been updated.
- [ ] Sufficient inline comments ensure readability by other contributors in the long term.
#### Documentation site
- [ ] The modifications to *fMRIPrep* in this PR **do not require extra documentation**. This is a common situation when a bug fix that does not change the code base substantially is submitted.
- [ ] This PR requires documentation. The corresponding documentation will be submitted as an additional PR in the future.
- [ ] This PR requires extra documentation, and will be included within this PR. Please check the boxes that apply best:
- [ ] An existing feature is substantially modified, changing the interface and/or logic of a module.
- [ ] A new feature is being added, therefore full documentation of it will be included
- [ ] This PR addresses an error in existing documentation.
- [ ] Yes, all expected sections of documentation were generated by the CI build, and look as expected
#### Tests
- [ ] The new functionalities in this PR are covered by the existing tests
- [ ] New test batteries have been included with this PR
#### Data
- [ ] This PR does not require any additional data to be uploaded to OSF.
- [ ] This PR requires additional data for tests.
#### Dependencies: smriprep
- [ ] This PR does not require any update on `smriprep`; or
- [ ] `smriprep` has correctly been pinned.
#### Dependencies: niworkflows
- [ ] This PR does not require any update on `niworkflows`; or
- [ ] `niworkflows` has correctly been pinned.
#### Dependencies: sdcflows
- [ ] This PR does not require any update on `sdcflows`; or
- [ ] `sdcflows` has correctly been pinned.
#### Dependencies: Nipype
- [ ] This PR does not require any update on `nipype`; or
- [ ] `nipype` has correctly been pinned.
#### Dependencies: other
- [ ] This PR does not require any update on other dependencies; or
- [ ] other dependencies have correctly been pinned.
#### Reports generated within CI tests
- [ ] Yes, I have checked the reports of ds005 and they are not modified or the changes are as expected
- [ ] Yes, I have checked the reports of ds054 and they are not modified or the changes are as expected
- [ ] Yes, I have checked the reports of ds010 and they are not modified or the changes are as expected
### Review Comments (other than those left inline with the code)
|
oesteban
force-pushed
the
fix/1777
branch
2 times, most recently
from
79992f8
to
b6c0be4
Compare
Adds a bugfix and a test-case. Close nipreps#1777.
…kip ds054][skip ds210][skip tests] before this change, tests would break because templateflow attempts to use home first, and the docker run command would have mounted it with readonly. now this is implemented separately, and a safe new $HOME mocked. Close nipreps#1777.
|
Okay, it seems #1836 consistently fixed the failing build_docs. The tests are run and functioning as expected. Merging. |
effigies
added a commit
to nipreps/mriqc
that referenced
this pull request
Oct 8, 2020
Fixes #853. Following nipreps/fmriprep#1830.
effigies
added a commit
to nipreps/mriqc
that referenced
this pull request
Dec 12, 2020
Fixes #853. Following nipreps/fmriprep#1830.
effigies
added a commit
to nipreps/mriqc
that referenced
this pull request
Dec 13, 2020
Fixes #853. Following nipreps/fmriprep#1830.
effigies
added a commit
to nipreps/mriqc
that referenced
this pull request
Dec 15, 2020
Fixes #853. Following nipreps/fmriprep#1830.
effigies
added a commit
to nipreps/mriqc
that referenced
this pull request
Dec 16, 2020
Fixes #853. Following nipreps/fmriprep#1830.
oesteban
pushed a commit
to nipreps/nireports
that referenced
this pull request
Feb 28, 2023
Fixes #853. Following nipreps/fmriprep#1830.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a bugfix and a test-case. Close #1777.