FIX: ensure commandline aliases are respected #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
effigies
approved these changes
May 29, 2020
oesteban
reviewed
May 29, 2020
| @@ -150,6 +150,7 @@ def _bids_filter(value): | |||
| "--nthreads", | |||
| "--n_cpus", | |||
| "--n-cpus", | |||
| dest='nprocs', | |||
There was a problem hiding this comment.
why is not --nprocs used as dest?
There was a problem hiding this comment.
i think it'd be nice to have it explicitly said, especially since this changed from 20.0.x
There was a problem hiding this comment.
explicitly said
Well, developers know that argparse maps --nprocs to parsed.nprocs if it is placed first (which is implicit, but clear in their API). To the user, I don't think this makes any difference. Should we define dest for all arguments then?
There was a problem hiding this comment.
if they all had multiple aliases like this one, i tend to side with "yes"
oesteban
approved these changes
Jun 1, 2020
mgxd
added a commit
that referenced
this pull request
Jun 4, 2020
20.1.1 (June 04, 2020) ====================== Bug-fix release in the 20.1.x series. * FIX: FreeSurfer license manipulation & canary (#2165) * FIX: Dismiss ``echo`` entity from SDC reports (#2160) * FIX: Ensure the command-line alias of ``--nprocs`` is respected (#2152) * MAINT: Use legacy pip/setuptools for py2 checking (#2156)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2151
There are many aliases for the
nprocsoption, but we were not being consistent with the dest variable.Also fixes an invalid nipype plugin argument (#2153 (comment))