Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Split aCompCor into aCompCor, cCompCor, wCompCor #2523

Merged
merged 7 commits into from
Sep 2, 2021
Merged

FIX: Split aCompCor into aCompCor, cCompCor, wCompCor #2523

merged 7 commits into from
Sep 2, 2021

Conversation

effigies
Copy link
Member

Fixes #2384.

@pep8speaks
Copy link

pep8speaks commented Aug 30, 2021 •
edited
Loading

Hello @effigies! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-09-02 20:12:34 UTC

@effigies effigies force-pushed the fix/split_compcors branch 2 times, most recently from 7f543e6 to ee7d185 Compare August 31, 2021 12:54
@effigies
Copy link
Member Author

renamed_confound

Also visible here: https://circle-production-customer-artifacts.s3.amazonaws.com/picard/forks/5d730ad8a6f141375eae36c4/78558509/612e2df12788b45e41dd37de-0-build/artifacts/tmp/ds210/derivatives/fmriprep/sub-02/func/sub-02_task-cuedSGT_run-1_desc-confounds_timeseries.json?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20210831T142808Z&X-Amz-SignedHeaders=host&X-Amz-Expires=60&X-Amz-Credential=AKIAJR3Q6CR467H7Z55A%2F20210831%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Signature=53682363bf33f3cd5e85aa213e9d90c9d0135367b3327d17a130b6e44335739b

Note: there are all these dropped_X metadata fields. Is there any advantage to having them in, or should we filter them out?

@effigies effigies added this to the 21.0.0 milestone Sep 1, 2021
mgxd
mgxd approved these changes Sep 2, 2021
View reviewed changes
Copy link
Collaborator

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments

fmriprep/interfaces/confounds.py
out_file = File(desc='filtered CompCor metadata')


class FilterDropped(SimpleInterface):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a docstring here?

fmriprep/interfaces/confounds.py
metadata_file = File(desc='output aCompCor metadata')


class RenameACompCor(SimpleInterface):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here?

@mgxd mgxd merged commit 20182c0 into nipreps:master Sep 2, 2021
@htwangtw htwangtw mentioned this pull request Sep 9, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgxd mgxd mgxd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
21.0.0
Development

Successfully merging this pull request may close these issues.

aCompCor components with different masks are inter-mixed
3 participants
@effigies @pep8speaks @mgxd