Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Re-enable reverse-PE EPI fieldmaps #2684

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

effigies
Copy link
Member

Requires nipreps/sdcflows#258.

Started testing on ds000223, and the workflow looks reasonable, but the affines are slightly different between EPI and BOLD. I'll look for another dataset or just hack the affines for now.

@effigies
Copy link
Member Author

Currently have TOPUP running with:

Node: single_subject_CSI1_wf (fmap_preproc_wf (wf_auto_00000 (topup (fsl)
=========================================================================


 Hierarchy : fmriprep_wf.single_subject_CSI1_wf.fmap_preproc_wf.wf_auto_00000.topup
 Exec ID : topup


Original Inputs
---------------


* args : <undefined>
* config : /opt/conda/lib/python3.8/site-packages/sdcflows/data/flirtsch/b02b0.cnf
* encoding_direction : ['y', 'y', 'y', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-', 'y-']
* encoding_file : <undefined>
* environ : {'FSLOUTPUTTYPE': 'NIFTI_GZ'}
* estmov : <undefined>
* fwhm : <undefined>
* in_file : /scratch/fmriprep_wf/single_subject_CSI1_wf/fmap_preproc_wf/wf_auto_00000/pad_blip_slices/sub-CSI1_ses-01_acq-PA_epi_idx-000_merged_padded.nii.gz
* interp : <undefined>
* max_iter : <undefined>
* minmet : <undefined>
* numprec : <undefined>
* out_base : <undefined>
* out_corrected : <undefined>
* out_field : <undefined>
* out_jac_prefix : jac
* out_logfile : <undefined>
* out_mat_prefix : xfm
* out_warp_prefix : warpfield
* output_type : NIFTI_GZ
* readout_times : [0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788, 0.0568788]
* reg_lambda : <undefined>
* regmod : <undefined>
* regrid : <undefined>
* scale : <undefined>
* splineorder : <undefined>
* ssqlambda : <undefined>
* subsamp : <undefined>
* warp_res : <undefined>

That's 3 EPI and 50 BOLD volumes, which is what the old behavior was.

This is on ds001499, btw.

Copy link
Collaborator

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

raise NotImplementedError(
"Sophisticated PEPOLAR schemes are unsupported."
)
suffices = [s.suffix for s in estimator.sources]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just so i'm clear - this was changed to ensure there is only 1 bold / fmap pair in the estimation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that or all EPI, which we previously allowed.

@effigies effigies merged commit 2378f91 into nipreps:maint/21.0.x Jan 14, 2022
@effigies effigies added this to the 21.0.1 milestone May 27, 2022
@effigies effigies deleted the fix/reenable_reverse_pe_epi branch August 24, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants