DOCKER: Build wheel and install in two-stage build #2859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
force-pushed
the
docker/wheel
branch
from
62a0de2
to
3f28bda
Compare
effigies
commented
Sep 26, 2022
| .zenodo.json | ||
| .travis.yml | ||
| .readthedocs.yml | ||
| CONTRIBUTING.md |
There was a problem hiding this comment.
These things were removed to avoid getting a dirty repository. We now do not do a COPY . outside of the wheel building stage, so this should not pollute the image.
| RUN apt-get update && \ | ||
| apt-get install -y --no-install-recommends git | ||
| COPY . /src/fmriprep | ||
| RUN python -m build /src/fmriprep |
There was a problem hiding this comment.
I've tested locally. Modifying the repository will make this rerun but will not cause a cache miss on L33+ until there's another change in the Dockerfile or a COPY/ADD command fails a hash check.
effigies
force-pushed
the
docker/wheel
branch
2 times, most recently
from
1352a77
to
918c856
Compare
mgxd
approved these changes
Sep 27, 2022
effigies
force-pushed
the
docker/wheel
branch
from
76e9866
to
9ff8d68
Compare
[skip ds005][skip ds054][skip ds210]
mgxd
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
This PR aims to make the Docker build less fragile by building the package wheel in an initial stage with full git information, and then copying only the wheel over to the main build.
Assuming that the COPY at L29 doesn't break the caching of everything afterwards, then we should be good. Otherwise we can switch to something like:
This will also allow us to stop using a custom versioneer.