Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Generate more verbose reports (here, showing fieldmaps) if running in debug mode #2872

Merged
merged 6 commits into from
Oct 11, 2022

Conversation

oesteban
Copy link
Member

@oesteban oesteban commented Oct 6, 2022

This PR drafts a missing component for a faster assessment of problems with fieldmaps.

@oesteban oesteban marked this pull request as ready for review October 7, 2022 15:21
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2022

Codecov Report

Base: 44.71% // Head: 44.88% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (1a9aa1a) compared to base (786673b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2872      +/-   ##
==========================================
+ Coverage   44.71%   44.88%   +0.16%     
==========================================
  Files          43       43              
  Lines        3509     3516       +7     
==========================================
+ Hits         1569     1578       +9     
+ Misses       1940     1938       -2     
Impacted Files Coverage Δ
fmriprep/workflows/bold/base.py 16.46% <0.00%> (-0.49%) ⬇️
fmriprep/_version.py 42.09% <0.00%> (+2.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few comments

fmriprep/workflows/bold/base.py Outdated Show resolved Hide resolved
fmriprep/workflows/bold/base.py Outdated Show resolved Hide resolved
fmriprep/workflows/bold/base.py Outdated Show resolved Hide resolved
Co-authored-by: Mathias Goncalves <mathiasg@stanford.edu>
@effigies effigies merged commit fdac850 into master Oct 11, 2022
@effigies effigies deleted the maint/coeff2epi-debugging branch October 11, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants