Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Test on Python 3.10, bump actions versions #2895

Merged
merged 8 commits into from
Nov 30, 2022

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Nov 23, 2022

No description provided.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted my comment at #2894 (comment), but meant to do it here:

It doesn't seem to be new pip. Installing pip 22.1 in a Python 3.7 environment produces the same issue for me. I think there must be something in the dependency chain that's causing a resolution failure in 3.7. Pip's resolution mechanism is to find older and older versions of a tool, and we eventually found a nitime that is so old that it imports the entire module and breaks because numpy isn't a build dependency.

I think the thing to do is to drop Python 3.7. NEP29 recommended dropping it almost a year ago, and I assume that what we're seeing is the consequences of the broader ecosystem no longer testing on it. It's probably not worth a lot of effort tracking this down.

I would suggest we take one of the following routes:

  1. Adhere to NEP29 and drop Python minor releases along with the rest of the ecosystem.
  2. Continue testing and advertise support for non-EOL Pythons until the fixes become non-obvious.

.github/workflows/stable.yml Outdated Show resolved Hide resolved
@effigies effigies marked this pull request as ready for review November 30, 2022 20:01
@effigies
Copy link
Member

Skipping over Circle builds.

@effigies effigies merged commit ff872d3 into nipreps:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants