Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Split fMRIPrep into fit and derivatives workflows #2913

Merged
merged 36 commits into from
Aug 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
924eee0
ENH: Upgrade FreeSurfer to 7.3.2
effigies Jan 18, 2023
6a7a9d9
MNT: Try reducing FreeSurfer size by excluding large and test Python …
effigies Jan 18, 2023
318c03e
DOCKER: Switch to conda for convert3d
effigies Jan 10, 2023
6018f4d
DOCKER: Install libpng12 from PPA
effigies Jan 11, 2023
e91607f
DOC: Update versions in documentation
effigies Jan 11, 2023
533574d
CI: Bump build cache
effigies Jan 11, 2023
d65768d
PIN: smriprep feature branch
effigies Dec 13, 2022
8d8989e
CLI: Rename --anat-derivatives to --derivatives
effigies Jan 18, 2023
23d8c2b
RF: Collect pre-computed anatomical derivatives using new machinery
effigies Jan 19, 2023
66cb0bb
RF: Compute T1w-fsnative transform LTA from fsnative2t1w_xfm
effigies Jan 19, 2023
fdb69c0
WRAPPER: Update CLI arguments
effigies Jan 19, 2023
28805d6
CI: Update FASTRACK_ARG to use --derivatives
effigies Jan 19, 2023
c6ce78f
CI: Drop fasttrack output files; precomputed files are copied
effigies Jan 19, 2023
7799007
Merge remote-tracking branch 'upstream/next' into rf/split_workflow
effigies Jun 19, 2023
dbfcd83
CI: Disable output checks, just show results
effigies Jun 20, 2023
ca29568
Merge remote-tracking branch 'upstream/next' into rf/split_workflow
effigies Jul 4, 2023
f683374
MNT: Pin sdcflows feature branch
effigies Jul 12, 2023
3653415
WIP: Refactor fit workflow
effigies Jul 19, 2023
45ee799
Draft to create the boldref for coregistration to T1w.
feilong Jul 20, 2023
0886911
ENH: Add io spec for expected outputs from "fit" portion
mgxd Jul 21, 2023
a3df303
Merge remote-tracking branches 'upstream/next', 'feilong/rf/split_wor…
effigies Jul 22, 2023
c331d1d
Add `-output-weights-text` to `-volume-to-surface-mapping`
HippocampusGirl Jul 23, 2023
fca539c
Revert "MNT: Pin sdcflows feature branch"
effigies Jul 23, 2023
c864194
Merge remote-tracking branch 'HippocampusGirl/output-weights-text' in…
effigies Jul 30, 2023
3ae7e69
Merge remote-tracking branch 'upstream/next' into rf/split_workflow
effigies Aug 1, 2023
b2e14d9
RF: Move fit workflow to workflows.bold.fit
effigies Aug 9, 2023
ac097da
RF: Add single subject fit workflow
effigies Aug 9, 2023
c1ed7d0
FIX: Do not assume sbrefs
effigies Aug 15, 2023
536fcb7
FIX: Correctly detect previous runs of fMRIPrep
effigies Aug 15, 2023
03a07bc
FIX: Typos, logic errors, and unfinished refactors
effigies Aug 15, 2023
3dfa667
ENH: Add data loader class
effigies Aug 15, 2023
a5f1d29
FIX: Disable report writing in coreg
effigies Aug 16, 2023
e6e0d09
ENH: Output coregistration transforms
effigies Aug 16, 2023
a2ebb99
ENH: Hook up fieldmaps to BOLD processing
effigies Aug 16, 2023
bbf042b
FIX: Badtab
effigies Aug 16, 2023
1c40fb9
ENH: Sink boldref2fmap transforms
effigies Aug 17, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
32 changes: 7 additions & 25 deletions .circleci/config.yml
Expand Up @@ -88,27 +88,9 @@ _setup_fmriprep_docker: &setup_fmriprep_docker
pip install --upgrade /tmp/src/fmriprep/wrapper/

_check_outputs: &check_outputs
name: Checking outputs of fMRIPrep run
name: Show outputs of fMRIPrep run
command: |
set +e -x
mkdir -p /tmp/${DATASET}/test
find /tmp/${DATASET}/${SUBDIR:-derivatives} \( -path '*/figures' -o -path '*/log' -o -path '*/sourcedata' \) -prune -o -name "*" -print | cut -d/ -f 5- | sort > /tmp/${DATASET}/test/outputs.out

FASTTRACK_OUTPUTS="${DATASET}${VARIANT}_fasttrack_outputs.txt"
FULL_OUTPUTS="${DATASET}${VARIANT}_outputs.txt"
RET=1
if [ ! -f /tmp/.nofasttrack ]; then
echo "Checking fasttrack..."
diff /tmp/src/fmriprep/.circleci/${FASTTRACK_OUTPUTS} /tmp/${DATASET}/test/outputs.out
RET=$?
fi
if [ $RET -ne 0 ]; then
echo "Checking full..."
diff /tmp/src/fmriprep/.circleci/${FULL_OUTPUTS} /tmp/${DATASET}/test/outputs.out
RET=$?
fi
exit $RET

find /tmp/${DATASET}/${SUBDIR:-derivatives} \( -path '*/figures' -o -path '*/log' -o -path '*/sourcedata' \) -prune -o -name "*" -print | cut -d/ -f 5- | sort

version: 2.1
aliases:
Expand Down Expand Up @@ -488,7 +470,7 @@ jobs:
name: Run full fMRIPrep on ds005 (LegacyMultiProc plugin)
no_output_timeout: 2h
command: |
FASTRACK_ARG="--anat-derivatives /tmp/${DATASET}/smriprep"
FASTRACK_ARG="--derivatives anat=/tmp/${DATASET}/smriprep"
if [ -f /tmp/.nofasttrack ]; then
FASTRACK_ARG=""
fi
Expand Down Expand Up @@ -536,7 +518,7 @@ jobs:
name: Re-run with BIDS layout
no_output_timeout: 2h
command: |
FASTRACK_ARG="--anat-derivatives /tmp/${DATASET}/smriprep"
FASTRACK_ARG="--derivatives anat=/tmp/${DATASET}/smriprep"
if [ -f /tmp/.nofasttrack ]; then
FASTRACK_ARG=""
fi
Expand All @@ -562,7 +544,7 @@ jobs:
no_output_timeout: 2h
command: |
rm /tmp/data/${DATASET}/sub-01/func/*_run-01_*
FASTRACK_ARG="--anat-derivatives /tmp/${DATASET}/smriprep"
FASTRACK_ARG="--derivatives anat=/tmp/${DATASET}/smriprep"
if [ -f /tmp/.nofasttrack ]; then
FASTRACK_ARG=""
fi
Expand Down Expand Up @@ -669,7 +651,7 @@ jobs:
name: Run full fMRIPrep on ds054
no_output_timeout: 2h
command: |
FASTRACK_ARG="--anat-derivatives /tmp/${DATASET}/smriprep"
FASTRACK_ARG="--derivatives anat=/tmp/${DATASET}/smriprep"
if [ -f /tmp/.nofasttrack ]; then
FASTRACK_ARG=""
fi
Expand Down Expand Up @@ -791,7 +773,7 @@ jobs:
name: Run full fMRIPrep on ds000210
no_output_timeout: 2h
command: |
FASTRACK_ARG="--anat-derivatives /tmp/${DATASET}/smriprep"
FASTRACK_ARG="--derivatives anat=/tmp/${DATASET}/smriprep"
if [ -f /tmp/.nofasttrack ]; then
FASTRACK_ARG=""
fi
Expand Down
33 changes: 0 additions & 33 deletions .circleci/ds005_bids_fasttrack_outputs.txt

This file was deleted.

42 changes: 0 additions & 42 deletions .circleci/ds005_legacy_fasttrack_outputs.txt

This file was deleted.

59 changes: 0 additions & 59 deletions .circleci/ds005_legacy_partial_fasttrack_outputs.txt

This file was deleted.

68 changes: 0 additions & 68 deletions .circleci/ds054_fasttrack_outputs.txt

This file was deleted.