FIX: Remove bad metadata input from ds_goodvoxels_mask #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgxd
approved these changes
Jun 14, 2023
effigies
added a commit
that referenced
this pull request
Jun 14, 2023
23.1.1 (June 14, 2023) Bug fix release in the 23.1.x series. This release corrects a small error that prevented the "goodvoxels" mask from being placed in the output directory if no FreeSurfer output spaces were specified. * FIX: Remove bad metadata input from ds_goodvoxels_mask (#3037)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Currently we're creating the following
.jsonfile forgoodvoxels_mask:{ "keys": [ "fsaverage5", "fsnative" ] }This is not serving any useful purpose and needs to be deleted. Looking up masks, we can put in some recommended metadata, such as the type of mask it is. I don't want to figure out sources right now.
Closes #3035.