Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATCH: Use mutualinfo cost function for MCFLIRT #3062

Closed
wants to merge 2 commits into from

Conversation

effigies
Copy link
Member

Testing out a super quick fix for #3056. This is not the long-term fix, which will be to stop using sbrefs at HMC and start with coregistration.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0ed3a93) 49.43% compared to head (b5619db) 49.43%.
Report is 23 commits behind head on master.

❗ Current head b5619db differs from pull request most recent head b3917c2. Consider uploading reports for the commit b3917c2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3062   +/-   ##
=======================================
  Coverage   49.43%   49.43%           
=======================================
  Files          46       46           
  Lines        3599     3599           
=======================================
  Hits         1779     1779           
  Misses       1820     1820           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgxd
Copy link
Collaborator

mgxd commented Jul 21, 2023

I SSHed in to check if sort has changed:

ubuntu-2204:2023.07.2

$ sort --version
sort (GNU coreutils) 8.32
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

ubuntu-2204:2023.04.2

$ sort --version
sort (GNU coreutils) 8.32
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

which leads me to believe it's an error in caching

@effigies
Copy link
Member Author

Then why did this work? I didn't bump the cache.

@effigies
Copy link
Member Author

It could be a corrupt glibc...

@effigies
Copy link
Member Author

Pushed a docker branch for easier testing: docker/23.1.x+mutualinfo

@effigies effigies closed this Jul 31, 2023
@effigies effigies deleted the patch/mcflirt-mi branch July 31, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants