Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Swap direction of fmap-EPI transform #3106

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

effigies
Copy link
Member

Changes proposed in this pull request

#3099 introduced a subtle bug where we applied the inverse transform of what we needed. This is because init_unwarp_wf and init_coeff2epi_wf have opposite conventions (point and image) for describing transforms.

This could be swapped in sdcflows, but I intend to replace unwarp_wf with our resampler, so this is just doing the job correctly in the meantime.

@effigies effigies added the next label Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (511c838) 47.24% compared to head (3688554) 47.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3106   +/-   ##
=======================================
  Coverage   47.24%   47.24%           
=======================================
  Files          49       49           
  Lines        4009     4009           
=======================================
  Hits         1894     1894           
  Misses       2115     2115           
Files Coverage Δ
fmriprep/workflows/bold/fit.py 25.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 737d59e into nipreps:next Oct 12, 2023
11 checks passed
@effigies effigies deleted the fix/unwarp-xfm-direction branch October 12, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant