Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unselected subjects in BIDSLayoutIndexer #3236

Merged
merged 6 commits into from
Mar 9, 2024

Conversation

tsalo
Copy link
Collaborator

@tsalo tsalo commented Feb 23, 2024

Closes #3235.

Changes proposed in this pull request

  • Incorporate a regular expression in the ignore list of the BIDSLayoutIndexer that flags subjects who are not in Config.participant_label (when provided).

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.68%. Comparing base (ffc3810) to head (46e05b9).
Report is 12 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3236       +/-   ##
===========================================
- Coverage   73.24%   51.68%   -21.57%     
===========================================
  Files          54       54               
  Lines        4160     4164        +4     
===========================================
- Hits         3047     2152      -895     
- Misses       1113     2012      +899     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fmriprep/config.py Outdated Show resolved Hide resolved
@effigies effigies added this to the 24.0.0 milestone Feb 29, 2024
fmriprep/config.py Outdated Show resolved Hide resolved
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this as-is. LMK if you want to try to improve the regex.

@effigies
Copy link
Member

effigies commented Mar 8, 2024

Okay, it looks like we are using re.search not re.match in pybids, which means we need to consider _, which is considered a word character.

@effigies effigies merged commit c46c893 into nipreps:master Mar 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore all subjects except the requested ones in BIDSLayout initialization
2 participants