Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM] FIX: Reduce interpolation artifacts in ConformSeries #564

Merged
merged 3 commits into from Jun 17, 2017

Conversation

effigies
Copy link
Member

This PR attempts to make the conformation step minimally disruptive.

  • Rescaling and resizing operations are logically separated in calculating the target affine
  • Rescaling is only applied if there is a > 0.05mm difference between the original and target zooms
  • Resizing is restricted to an integer shift, rather than scaling the intercept; this should avoid half-voxel interpolations if an odd number of voxels are tacked on
  • The original image header is copied to the target, reducing the divergence of the header only to changes induced by an updated affine

Additionally, symlinks are disallowed for untouched files, so that the working directory can be created by a docker image and inspected outside.

Fixes #562.

Logically separate rescaling and resizing to avoid excess interpolation
@effigies effigies requested a review from chrisgorgo June 16, 2017 20:57
@chrisgorgo
Copy link
Contributor

I assume you have tested that this indeed fixes #562. Correct?

@effigies
Copy link
Member Author

I ran through autorecon1 on sub-07 with no issues, and orig.mgz now looks more reasonable. Running sub-09 now...

@effigies
Copy link
Member Author

sub-09 is working, as well. I did screw up sub-02, however. I think it's the shift that went wrong.

@effigies
Copy link
Member Author

Okay, I believe I've fixed it, but I'm going to need to rerun tests for each subject to verify...

@effigies
Copy link
Member Author

Tested on ds114 sub-02, sub-07 and sub-09. This is good to go.

@effigies effigies changed the title FIX: Reduce interpolation artifacts in ConformSeries [RTM] FIX: Reduce interpolation artifacts in ConformSeries Jun 17, 2017
@chrisgorgo chrisgorgo merged commit 22f0744 into nipreps:master Jun 17, 2017
@effigies effigies deleted the fix/conformation branch June 17, 2017 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants