Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM] FIX: Add second reorient step, in case LIA image is created #637

Merged
merged 1 commit into from
Aug 4, 2017

Conversation

effigies
Copy link
Member

@effigies effigies commented Aug 2, 2017

This PR adds a second ConformSeries step post-merge, which ensures that the final template is RAS oriented. This reduces to a nibabel.as_closest_canonical, and will not make a new copy (even in memory) if the input is already RAS.

Fixes #636

@effigies effigies changed the title FIX: Add second reorient step, in case LIA image is created [RTM] FIX: Add second reorient step, in case LIA image is created Aug 2, 2017
@effigies
Copy link
Member Author

effigies commented Aug 3, 2017

@chrisfilo WDYT? Now that this stage is three nodes (conform -> template -> reorient), it may also make sense to abstract into a sub-workflow, just to keep the main workflow clean.

Especially if we produce affine transforms to relate the input images to the outputs (#628), which after talking to Satra does seem like a good idea to me, I think it'll be necessary, but that's also a refactoring that can go in that PR.

@chrisgorgo
Copy link
Contributor

I think extracting this is a good idea, but we should leave it until this patter will be used more than once.

As for transformation matrices I asked Satra if he really has a use for them.

@effigies effigies merged commit 3178d77 into nipreps:master Aug 4, 2017
@effigies
Copy link
Member Author

effigies commented Aug 4, 2017

Sounds good. Merging.

@effigies effigies deleted the fix/reorient branch August 4, 2017 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merged anatomicals are in LIA orientation, not RAS
2 participants