Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSL-less version #1032

Closed
araikes opened this issue Oct 7, 2022 · 2 comments · Fixed by #1108
Closed

FSL-less version #1032

araikes opened this issue Oct 7, 2022 · 2 comments · Fixed by #1108

Comments

@araikes
Copy link
Contributor

araikes commented Oct 7, 2022

HI @oesteban,

I love MRIQC but have a particular application for which an FSL-less version (or at least a version that gives an "no FSL" running option) would be invaluable. I know there had been some effort to move in that direction at one point and I'm just curious what the status might be.

Thanks

@oesteban
Copy link
Member

The plan is clear, and the tooling around MRIQC seems going in the right direction (e.g., the recent addition of SynthStrip for brain extraction).

Are you most interested on anatomical images, BOLD, or both anatomical and functional?

@araikes
Copy link
Contributor Author

araikes commented Oct 10, 2022

Ideally, we're looking for the ability to run both pipelines, however anatomical would be the priority.

oesteban added a commit that referenced this issue Mar 29, 2023
oesteban added a commit that referenced this issue Mar 29, 2023
oesteban added a commit that referenced this issue Mar 29, 2023
@oesteban oesteban mentioned this issue Mar 29, 2023
3 tasks
oesteban added a commit that referenced this issue Mar 30, 2023
This PR contributes toward #1032 by eliminating the need for FSL BET.

By using an implementation closer to the gradient-based of (Mortamet,
2009), there is no more need for BET.
oesteban added a commit that referenced this issue Apr 1, 2023
oesteban added a commit that referenced this issue Apr 1, 2023
oesteban added a commit that referenced this issue Apr 3, 2023
After careful consideration, I'm proposing to drop the ``--ica``
argument of the functional workflow, to continue toward eliminating
FSL as a dependency.

The reason is that the ICA decomposition does not seem (alone)
sufficient to assess the quality.
Or at least, the kind of problems/artifacts you can pick with just the
ICA decomposition (without assistance like CompCor, AROMA or FIX) are
typically identifiable with the standard deviation image and other
mosaics.

I would not be against adding sklearn's FastICA or a reimplementation
of MELODIC to have the ICA + EM mixtrue modelling, but, for now, I
believe the priority should be to finally remove FSL, even if that means
discontinuing a feature.

Other than the visual reports, there's no other side effect since we are
currently not calculating any IQMs from the ICA results (which would be
a very interesting addition in the future, perhaps with some AROMA
assistance).

Relates: #1032.
oesteban added a commit that referenced this issue Apr 3, 2023
oesteban added a commit that referenced this issue Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants