Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong filename when downloading json file from rating widget [unknown_unspecified.json] #1127

Closed
jaimebarran opened this issue Jul 3, 2023 · 1 comment · Fixed by #1188
Closed
Labels

Comments

@jaimebarran
Copy link

jaimebarran commented Jul 3, 2023

What happened?

I added the plugin 'rating widget' to mri qc report generation. The reports were well built, but when I tried to qualify subjectively the quality of the image with the rating widget, the downloaded file is always with the same filename: unknown_unspecified.json.
It would be good that the filename would be as: dataset_subject.json.

What command did you use?

I built the docker image myself, but that worked. The thing that didn't work was the rating widget created along with the report (when downloading the json file).
My command to run the docker was:

docker run -it --rm -v /home/jaimebarranco/Desktop/samples_v3_bids:/data:ro -v /home/jaimebarranco/Desktop/mreyeqc_output:/out mreyeqc:latest /data /out participant --participant_label 001

What version of the software are you running?

"""Version file, automatically generated by setuptools_scm.""" version = "0.1.dev3288+g5f95281.d20230628"

How are you running this software?

Docker

Is your data BIDS valid?

Yes

Are you reusing any previously computed results?

No

Please copy and paste any relevant log output.

No response

Additional information / screenshots

Files to look at:

  1. mriqc:
  • mriqc/reports/individual.py
  • mriqc/data/bootstrap-anat.yml
  1. nireports:
  • nireports/assembler/report.py
  • nireports/assembler/data/rating-widget/bootstrap.yml
  • nireports/assembler/data/rating-widget/footer.tpl
  • nireports/assembler/data/rating-widget/header.tpl
@celprov
Copy link
Collaborator

celprov commented Mar 6, 2024

Hi @jaimebarran,
Thanks for this good suggestion.
#1188 will solve the bug regarding the subject name being unspecified.
For the dataset being unknown, adding the --dsname <dataset_name> flag when running MRIQC would solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants