Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiling does not seem to be working #459

Closed
chrisgorgo opened this issue Apr 16, 2017 · 3 comments · Fixed by #981
Closed

Profiling does not seem to be working #459

chrisgorgo opened this issue Apr 16, 2017 · 3 comments · Fixed by #981
Labels
bug
Milestone
22.0.0

Comments

@chrisgorgo
Copy link
Collaborator

From latest master: https://1661-49015296-gh.circle-artifacts.com/0/home/ubuntu/scratch/out/logs/run_stats.log#

All runtime_memory_gb is either "Unknown" or 0.0. I don't think this ever worked - this is the log from the PR enabling profiling: https://1652-49015296-gh.circle-artifacts.com/0/home/ubuntu/scratch/out/logs/run_stats.log#
@chrisgorgo chrisgorgo added the bug label Apr 16, 2017
@chrisgorgo
Copy link
Collaborator Author

The reason why profiling does not work is because the 'profile_runtime' execution config option is not set to true. This config option is only respected if it is set in a config file - not programmatically.

@chrisgorgo chrisgorgo mentioned this issue May 6, 2017
Closed
@stale
Copy link

stale bot commented Aug 15, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 15, 2018
@stale stale bot closed this as completed Aug 22, 2018
@oesteban
Copy link
Member

I'll check on this soon and reopen if it is still not working.

@oesteban oesteban reopened this Mar 24, 2020
@oesteban oesteban removed the stale label Mar 24, 2020
@oesteban oesteban added this to the 22.0.0 milestone Mar 13, 2022
oesteban added a commit that referenced this issue Apr 18, 2022
@oesteban
FIX: Resource profiler was broken with config file
827f8b2 
This PR addresses a long-standing problem introduced with the config
file. Since MRIQC uses the ``--profiler`` flag and it is not marked up
with a ``dest="resource_monitor"`` for argparse, then the resource
monitor of Nipype is never enabled.

Resolves: #459.
@oesteban oesteban mentioned this issue Apr 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
22.0.0
Development

Successfully merging a pull request may close this issue.

FIX: Resource profiler was broken with config file nipreps/mriqc
2 participants
@chrisgorgo @oesteban