Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] CNR calculation is wrong, should use background mask #475

Closed
oesteban opened this issue May 2, 2017 · 1 comment · Fixed by #513
Closed

[BUG] CNR calculation is wrong, should use background mask #475

oesteban opened this issue May 2, 2017 · 1 comment · Fixed by #513
Assignees
@oesteban
Labels
bug sMRI
Milestone
MRIQC 0.9.5

Comments

@oesteban
Copy link
Member

oesteban commented May 2, 2017

Particularly, this line: https://github.com/poldracklab/mriqc/blob/master/mriqc/qc/anatomical.py#L269 does not make any sense.
@oesteban oesteban self-assigned this May 2, 2017
@oesteban oesteban modified the milestone: MRIQC 0.9.5 May 17, 2017
@oesteban oesteban mentioned this issue May 22, 2017
Merged
oesteban added a commit to oesteban/mriqc that referenced this issue May 22, 2017
@oesteban
[ENH] Refactored structural metrics calculation
025d257 
- Centralizes computation of mu, sigma, etc.
- Revises use of masks, pv maps and derived masks
- Revises moments used in calculation of cjv, cnr, snr and snrd
  (fixes nipreps#475)
@oesteban oesteban mentioned this issue May 22, 2017
Merged
oesteban added a commit to oesteban/mriqc that referenced this issue May 24, 2017
@oesteban
several changes (see below)
4a14537 
- add median and mad to group plots
- centralize calculation of moments in `summary_stats`
- new definition of CNR (fixes nipreps#475)
@oesteban
Copy link
Member Author

I accidentally pushed master instead of the tag 0.9.5-rc1. I'll reopen untill tests pass.

@oesteban oesteban reopened this May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oesteban oesteban

Labels
bug sMRI
Projects
None yet
Milestone
MRIQC 0.9.5
Development

Successfully merging a pull request may close this issue.

[ENH] Refactored structural metrics calculation oesteban/mriqc
1 participant
@oesteban