Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove slice-timing correction #1019

Merged

Conversation

psadil
Copy link
Contributor

@psadil psadil commented Aug 15, 2022

Closes #998 by removing ability to correct for slice-timing (which had only worked for some acquisitions)

@psadil
Copy link
Contributor Author

psadil commented Aug 15, 2022

I'm not confident, but I think those failures are caused by changes outside this request. Perhaps I should have started from the last release rather than the master branch?

@oesteban
Copy link
Member

oesteban commented Aug 18, 2022

Thanks much for this. Can you please rebase to upstream/master? The errors should be fixed now.

Let's see if the tests indeed pass. When merged, please do not forget to add your info to https://github.com/nipreps/mriqc/blob/master/.maint/CONTRIBUTORS.md, in case you wish so.

@oesteban oesteban force-pushed the issue-998_remove-slice-timing-correction branch from 3de79e7 to d68baf6 Compare August 18, 2022 07:55
@oesteban oesteban merged commit 96b9b97 into nipreps:master Aug 18, 2022
@welcome
Copy link

welcome bot commented Aug 18, 2022

Thanks for opening this pull request and congratulations for taking it to the finish line! It looks like this is your first time contributing to MRIQC. 😄
We invite you to list yourself as an MRIQC contributor. To learn more about what that entails and how we credit our contributors, please check out the contributing guidelines. If your name is not already on the list, please insert it, in alphabetical order of (i) lastname and (ii) firstname, into the .maint/CONTRIBUTORS.md file.
Of course, if you want to opt-out this time, there is no problem at all with adding your name later. You will be always welcome to add it in the future whenever you feel it should be listed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--correct-slice-timing flag can have no effect (doc?)
2 participants