FIX: orientation of visualisations when species == "rat"
#1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @eilidhmacnicol, Thank you for updating! Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, Comment last updated at 2022-08-29 16:17:15 UTC |
|
Tested in docker container and seems to work nicely for example data (n = 1):
|
|
Let's keep |
oesteban
added a commit
to nipreps/nireports
that referenced
this pull request
Mar 9, 2023
Makes ``plot_mosaic`` more configurable to decide what view(s) are to be plotted, and which one will be the main view. Related: nipreps/mriqc#1027. Resolves: #1. Co-authored-by: Eilidh MacNicol <54267723+eilidhmacnicol@users.noreply.github.com>
oesteban
added a commit
to nipreps/nireports
that referenced
this pull request
Mar 9, 2023
Makes ``plot_mosaic`` more configurable to decide what view(s) are to be plotted, and which one will be the main view. Related: nipreps/mriqc#1027. Resolves: #1. Co-authored-by: Eilidh MacNicol <54267723+eilidhmacnicol@users.noreply.github.com>
oesteban
added a commit
to nipreps/nireports
that referenced
this pull request
Mar 9, 2023
Makes ``plot_mosaic`` more configurable to decide what view(s) are to be plotted, and which one will be the main view. Related: nipreps/mriqc#1027. Resolves: #1. Co-authored-by: Eilidh MacNicol <54267723+eilidhmacnicol@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually, rodent brains are viewed in the coronal orientation, as is the convention from physical atlases.
This updates the mosaic viz functions to change the orientation when
species == rat: coronal becomes the primary axis (instead of axial), while axial becomes the secondary axis (instead of sagittal)