ENH: Drop utilization of "head" mask from template #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR modifies the code to follow more closely (Mortamet et al., 2009). Now, the "hat" mask cuts through the through-plane axis (Z), which is more theoretically sound than the previous solution. cc/ @eilidhmacnicol because this will need some translation to rodents
|
@effigies - this requires nitransforms to open ITK's h5 files with only affines (it did before with nonlinear, not with just affines). So, if time permits, it would be nice to make sure nipy/nitransforms#174 gets through with a sound implementation. After so much time without working on nitransforms, your feedback will definitely be critical to ensure I don't merge a half-baked thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the code to follow more closely (Mortamet et al., 2009).
Now, the "hat" mask cuts through the through-plane axis (Z), which is more theoretically sound than the previous solution.
cc/ @eilidhmacnicol because this will need some translation to rodents