FIX: Move from pkg_resources to niworkflows.data.Loader
#1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Mar 19, 2024
| from nireports.assembler.report import Report | ||
| from niworkflows.data import Loader | ||
|
|
||
| _load_data = Loader(__package__) |
There was a problem hiding this comment.
I don't think this is going to work quite how you want. I'm pretty sure this will load relative to mriqc.reports.individual. I would suggest instead having data/__init__.py define load_data and import from there.
There was a problem hiding this comment.
would _load_data = Loader("mriqc") work?
|
Ouch. Thanks
…On Tue, Mar 19, 2024, 16:11 Chris Markiewicz ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In mriqc/reports/individual.py
<#1199 (comment)>:
> from nireports.assembler.report import Report
+from niworkflows.data import Loader
+
+_load_data = Loader(__package__)
I don't think this is going to work quite how you want. I'm pretty sure
this will load relative to mriqc.reports.individual. I would suggest
instead having data/__init__.py define load_data and import from there.
—
Reply to this email directly, view it on GitHub
<#1199 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAESDRS2UI5LUNVJMN7LKRLYZBISVAVCNFSM6AAAAABE5W7ODSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNBWGU3DMNJTGY>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg_resourcesis deprecated as an API.