Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: flake8 → ruff check #1212

Merged
merged 3 commits into from Mar 21, 2024
Merged

CI: flake8 → ruff check #1212

merged 3 commits into from Mar 21, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Mar 20, 2024

I have replaced the flake8 CI job with a ruff CI job.

I don't have much experience with pep8speaks. From .pep8speaks.yml:

    linter: flake8

Should I and can I change flake8 to ruff? I don't think pep8speaks supports ruff:

Any clue?

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review March 21, 2024 07:02
@oesteban
Copy link
Member

We should drop pep8speaks - we are slowly transitioning all projects to ruff (and only ruff).

Thanks for this!

@DimitriPapadopoulos
Copy link
Contributor Author

Thanks for removing the pep8speaks config file. We also need to remove the flake8 configuration from pyproject.toml.

@oesteban
Copy link
Member

Thanks for removing the pep8speaks config file. We also need to remove the flake8 configuration from pyproject.toml.

Do you want to go ahead and commit that?

@DimitriPapadopoulos
Copy link
Contributor Author

I don't have convenient access to GitHub right now, please proceed if you can.

@oesteban oesteban enabled auto-merge March 21, 2024 16:16
@oesteban oesteban merged commit 61b59e0 into nipreps:master Mar 21, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants