Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM] Add ICA component plots to MRIQC #412

Merged
merged 31 commits into from Apr 5, 2017
Merged

Conversation

chrisgorgo
Copy link
Collaborator

@chrisgorgo chrisgorgo commented Mar 8, 2017

@chrisgorgo
Copy link
Collaborator Author

chrisgorgo commented Mar 19, 2017

Pending merge of #431 and nipreps/niworkflows#134

@chrisgorgo chrisgorgo changed the title [WIP] Add ICA component plots to MRIQC [RTM] Add ICA component plots to MRIQC Mar 22, 2017
@@ -97,6 +97,8 @@ def anat_qc_workflow(dataset, settings, mod='T1w', name='anatMRIQC'):
norm = pe.Node(RobustMNINormalization(
num_threads=settings.get('ants_nthreads', 6), template='mni_icbm152_nlin_asym_09c',
testing=settings.get('testing', False), generate_report=True), name='SpatialNormalization')
norm.interface.num_threads = settings.get('ants_nthreads', 6)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it necessary to set the num_threads at the level of the interface?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the MultiProc plugin to work correctly.

@@ -362,6 +393,14 @@ def individual_reports(settings, name='ReportsWorkflow'):
(mosaic_spikes, mplots, [('out_file', 'in4')])
])

if settings.get('ica', False):
page_number = 4
if settings.get('fft_spikes_detector', False):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be fft_spikes_detector independent of ica?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are, but one has to come in the report before the other and thus the "in" ports need adjustment.

@chrisgorgo
Copy link
Collaborator Author

@oesteban (when you find a moment) Any thoughts about switching to BET for skullstripping?

@oesteban oesteban merged commit 8e9d60f into nipreps:master Apr 5, 2017
@oesteban
Copy link
Member

oesteban commented Apr 5, 2017

@chrisfilo I have the feeling that AFNI is a bit more reliable. It makes other kinds of mistakes (generally leaving out portions of ventricles), but I think those are less problematic. WDYT?

@chrisgorgo
Copy link
Collaborator Author

chrisgorgo commented Apr 5, 2017 via email

@oesteban
Copy link
Member

oesteban commented Apr 5, 2017

Oh sorry, for some reason I was thinking of T1w. Ok, for BOLD my impression is that BET generally works well, but we should first make some kind of normalization and maybe bias field correction. With those two we can get to a safe value for the frac option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants