[FIX] Datasets where air (hat) mask is empty #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oesteban
commented
May 31, 2017
•
oesteban
commented
- This PR fixes [BUG] IndexError: cannot do a non-empty take from an empty axes #528 by calculating replacement sigma and MAD from the sigmas and MADs found for the other tissues.
- Added documentation with a warning about this fact
- Seems to fix [BUG] ZeroDivisionError: float division by zero (SNRd) #527 as well (makes sense, since the origin of the problem is the hat mask again)
- This PR fixes nipreps#528 by calculating replacement sigma and MAD from the sigmas and MADs found for the other tissues. - Added documentation with a warning about this fact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.