Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Use nireports report generation #328

Merged
merged 3 commits into from
Dec 20, 2023
Merged

ENH: Use nireports report generation #328

merged 3 commits into from
Dec 20, 2023

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Dec 11, 2023

Start using nireports, rather than the legacy reporting in niworkflows. This ensures each <subject>-<session>.html reports only includes reportlets relevant to that subject/session pairing.

Additionally, a unique reportlet is generated per surface reconstruction method.

@mgxd mgxd marked this pull request as draft December 11, 2023 19:48
@mgxd mgxd marked this pull request as ready for review December 20, 2023 20:56
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (f6ad255) 32.81% compared to head (07eece0) 32.83%.

Files Patch % Lines
nibabies/workflows/anatomical/outputs.py 0.00% 6 Missing ⚠️
nibabies/reports/core.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   32.81%   32.83%   +0.02%     
==========================================
  Files          55       55              
  Lines        5321     5299      -22     
==========================================
- Hits         1746     1740       -6     
+ Misses       3575     3559      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgxd mgxd merged commit 7c8f110 into nipreps:master Dec 20, 2023
10 of 11 checks passed
@mgxd mgxd deleted the new/reports branch December 20, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant