Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix dwi module function cross ref in docstring #103

Merged
merged 4 commits into from
May 8, 2024

Conversation

jhlegarreta
Copy link
Collaborator

Fix dwi module function cross ref in docstring: provide the appropriate module where draw_points dwells.

Introduced inadvertently in commit 9f561d1 when the code was relocated from eddymotion.

Take advantage of the commit to improve the description of the method:

  • Specify how the colors are assigned.
  • Cross-reference the draw_points function using the Sphinx seealso tag.
  • Use the tilde to shorten the link: display only the function name without the modules.

@jhlegarreta
Copy link
Collaborator Author

Looks like the documentation is not being built correctly:
https://nireports--103.org.readthedocs.build/en/103/api/nireports.interfaces.dmri.html

Was already happening before:
https://nireports.readthedocs.io/en/latest/api/nireports.interfaces.dmri.html

The readthedocs log shows multiple failures related to the interfaces and reportlets modules. Warnings are the same as the ones reported in nipreps/sdcflows#439

Should be addressed in a separate PR.

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.43%. Comparing base (3c7f0bd) to head (977f26a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   58.27%   58.43%   +0.16%     
==========================================
  Files          22       22              
  Lines        2085     2086       +1     
  Branches      321      364      +43     
==========================================
+ Hits         1215     1219       +4     
+ Misses        787      783       -4     
- Partials       83       84       +1     
Flag Coverage Δ
unittests 58.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fix `dwi` module function cross ref in docstring: provide the
appropriate module where `draw_points` dwells.

Introduced inadvertently in commit 9f561d1 when the code was relocated
from `eddymotion`.

Take advantage of the commit to improve the description of the method:
- Specify how the colors are assigned.
- Cross-reference the `draw_points` function using the Sphinx `seealso`
  tag.
- Use the tilde to shorten the link: display only the function name
  without the modules.
@jhlegarreta jhlegarreta force-pushed the FixDWIFuncCrossRefInDocstring branch from 178b195 to 4340f64 Compare May 8, 2024 00:28
@effigies
Copy link
Member

effigies commented May 8, 2024

I think the problem is that we import from the package in docs/conf.py without installing it. Thus, imports like numpy fail before sphinx has an opportunity to use autodoc_mock_imports.

@effigies
Copy link
Member

effigies commented May 8, 2024

Hmm, no it is installed. Possibly the autodoc mock is interfering?

@effigies
Copy link
Member

effigies commented May 8, 2024

Looks like that fixed it: https://nireports--103.org.readthedocs.build/en/103/api/nireports.interfaces.dmri.html (I had to refresh the cache to see it.)

@effigies
Copy link
Member

effigies commented May 8, 2024

I fixed a couple small errors that were preventing the admonitions from being shown. Let me know if you'd rather they be pulled into a different PR.

@jhlegarreta
Copy link
Collaborator Author

Fine with me. Thanks for the investigation on the documentation failures Chris.

Will merge as soon as soon as CIs become green.

@effigies effigies merged commit 0347aeb into nipreps:main May 8, 2024
21 checks passed
@jhlegarreta jhlegarreta deleted the FixDWIFuncCrossRefInDocstring branch May 8, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants