Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept multiple EPIs/SBRefs for reference image calculation #399

Closed
tsalo opened this issue Sep 21, 2019 · 1 comment · Fixed by #408
Closed

Accept multiple EPIs/SBRefs for reference image calculation #399

tsalo opened this issue Sep 21, 2019 · 1 comment · Fixed by #408
Milestone
1.3.0

Comments

@tsalo
Copy link
Contributor

tsalo commented Sep 21, 2019 •
edited

init_bold_reference_wf currently accepts a single SBRef image and a single EPI run. With multi-echo EPI, however, there will generally be one SBRef and one EPI run for each echo. The current idea for fMRIPrep is to use just the first echo's SBRef/EPI as the reference image, but I think that it's likely that at some point some method will be developed that leverages the information across echoes. Therefore, it might be good to make sure that init_bold_reference_wf can accept a list of EPI/SBRef images, even if it just selects the first image internally for now.

This references nipreps/fmriprep#1745 (comment).
@tsalo tsalo changed the title Accept multiple SBRefs for reference image calculation Accept multiple EPIs/SBRefs for reference image calculation Sep 21, 2019
@emdupre
Copy link
Collaborator

emdupre commented Sep 24, 2019

Just wanted to 👍 -- this approach makes sense to me !

@tsalo tsalo mentioned this issue Oct 1, 2019
Merged
oesteban added a commit to oesteban/niworkflows that referenced this issue Oct 4, 2019
@oesteban
FIX: Remove unused, undocumented output from the bold_reference workflow
eee5bdb 
This was caught by @tsalo in nipreps#399. Pushing this change as it is
unrelated to that PR.
@oesteban oesteban mentioned this issue Oct 4, 2019
Merged
@tsalo tsalo mentioned this issue Mar 3, 2020
Merged
@oesteban oesteban added this to the 1.3.0 milestone May 28, 2020
bpinsard pushed a commit to bpinsard/niworkflows that referenced this issue Jun 26, 2020
@oesteban @bpinsard
FIX: Remove unused, undocumented output from the bold_reference workflow
530128d 
This was caught by @tsalo in nipreps#399. Pushing this change as it is
unrelated to that PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

ENH: Allow bold_reference_wf to accept multiple EPIs/SBRefs tsalo/niworkflows
3 participants
@oesteban @tsalo @emdupre