Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] resample sbref #253

Closed
wants to merge 3 commits into from
Closed

Conversation

chrisgorgo
Copy link
Contributor

Resample SBRef images if they don't match their BOLD files. Makes it more robust - SBRef with a non-matching grid is unlikely, but not inconceivable.

@oesteban oesteban added this to In progress in 0.6.x via automation Jan 18, 2019
@oesteban oesteban added this to In progress in pipelines Mar 6, 2019
@effigies effigies moved this from In progress to To do in pipelines Mar 12, 2019
@effigies effigies added the impact:low Estimated low impact task label Mar 12, 2019
@oesteban oesteban added the effort:medium Estimated medium effort task label Mar 16, 2019
oesteban added a commit to oesteban/niworkflows that referenced this pull request Apr 11, 2019
… 4D SBRefs are supplied as input.

This patch checks the dimensionality of SBRefs and generates an average if the SBRef is 4D.
Fixes nipreps/fmriprep#1579.
Intimately related to nipreps#253, although I'm not sure the proposed resampling there is absolutely necessary.
It could be detrimental for ``bbregister`` in co-registration.
It is very likely necessary for head-motion correction with either ``mcflirt`` or ``3dVolReg``.
@oesteban oesteban removed this from In progress in 0.6.x Apr 21, 2019
@franklin-feingold franklin-feingold moved this from To do to Issues B-list in pipelines May 6, 2019
@franklin-feingold franklin-feingold moved this from Issues B-list to Issues C-list in pipelines May 6, 2019
@oesteban oesteban removed this from Issues C-list in pipelines Feb 26, 2020
@oesteban
Copy link
Member

oesteban commented Mar 1, 2020

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- niworkflows/interfaces/registration.py  3
         

See the complete overview on Codacy

@effigies effigies closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:medium Estimated medium effort task impact:low Estimated low impact task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants