ENH: Ensure subcortical CIFTI is in LAS orientation #484
Conversation
|
Best reviewed: commit by commit
Optimal code review plan
|
Codecov Report
@@ Coverage Diff @@
## master #484 +/- ##
==========================================
+ Coverage 62.86% 62.90% +0.03%
==========================================
Files 41 41
Lines 5006 5003 -3
Branches 730 726 -4
==========================================
Hits 3147 3147
+ Misses 1708 1705 -3
Partials 151 151
Continue to review full report at Codecov.
|
| bold_img = _reorient_image(bold_img, target_img=label_img) | ||
| # ensure images match HCP orientation (LAS) | ||
| bold_img = _reorient_image(bold_img, orientation='LAS') | ||
| label_img = _reorient_image(label_img, orientation='LAS') |
There was a problem hiding this comment.
Is this going to be the case for all label files? Should we have a table mapping space to orientation?
There was a problem hiding this comment.
yes, since the final output should always be in LAS we want to ensure both BOLD / labels are as well prior to setting the IJK voxels
There was a problem hiding this comment.
I guess my reading of Tim's response was that LAS was an accident of the orientation of a specific template. Are we guaranteed that all templates HCP ever uses will be in LAS?
There was a problem hiding this comment.
no, we aren't - but that seems excessive for us to worry about. I'd rather mirror the outputs generated from HCP Pipelines, which happen to include the volume in LAS orientation
|
Ok. We can make this more complicated when they do. Merge when you like. |
Go one step beyond #477 and ensures volumetric output in LAS orientation.