Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-Polar SDC: Unify interface #18

Closed
oesteban opened this issue May 28, 2019 · 3 comments
Closed

PE-Polar SDC: Unify interface #18

oesteban opened this issue May 28, 2019 · 3 comments
Labels
Milestone

Comments

@oesteban
Copy link
Member

Currently, two important inputs are passed by argument (bold_meta, and epi_fmaps) and the other three (in_reference, in_reference_brain, in_mask) are passed by Nipype workflow inputs.

All of them should be workflow inputs.

@oesteban oesteban transferred this issue from nipreps/fmriprep Jul 9, 2019
@oesteban oesteban added this to the 1.0.0 milestone Aug 7, 2019
@mattcieslak
Copy link
Collaborator

Any thoughts on replacing bold with distorted and undistorted? A number of interfaces have bold_ref as both inputs and outputs. It might make sense to have inputs be distorted_ref and outputs be undistorted_ref. The boilerplate is also specific to bold, which is confusing when it's included in the html for preprocessed dwi data.

@effigies
Copy link
Member

@mattcieslak Perhaps open the bold -> (un)distorted issue separately? This got closed, but the closing PR didn't seem to address it.

@oesteban
Copy link
Member Author

Sorry for closing it, I thought it wasn't going to happen.

Yes, please open a new issue - I did not fully removed the term "bold" from the workflow because it'll take deeper changes to replace the enhance&skullstrip workflow with an equivalent with low b images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants