-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Output thickness, curvature, and sulcal depth files #305
Conversation
…e using to_scanner
…o derivatives yet
Co-authored-by: Christopher J. Markiewicz <effigies@gmail.com>
- Will require an update to `Path2BIDS` in niworkflows
Codecov ReportBase: 70.37% // Head: 68.86% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #305 +/- ##
==========================================
- Coverage 70.37% 68.86% -1.51%
==========================================
Files 17 17
Lines 1134 1169 +35
Branches 189 197 +8
==========================================
+ Hits 798 805 +7
- Misses 274 304 +30
+ Partials 62 60 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@effigies do you happen to know the BIDS compliant suffixes for |
That said, who knows what sorts of arguments will happen before that gets merged. |
Perfect, staying true to its FS equivalent 😄 Thanks, ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks right. Have you run and made sure that the data arrays in the output GIFTIs correspond to the correct FreeSurfer curvature files?
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
I have yet to run this on my own data |
CIFTIs generated by MRIsConvertData match their FS equivalents (loaded with |
smriprep/workflows/surfaces.py
Outdated
run_without_submitting=True, | ||
) | ||
fscurv2funcgii = pe.MapNode( | ||
MRIsConvertData(out_datatype="gii", to_scanner=True, target_surface="smoothwm"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lingering question: Should use the ?h.white
or ?h.smoothwm
surface files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think to_scanner
or target_surface
will make any difference here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgxd If you want to experiment with modifying/removing some args from fscurv2funcgii
(and actually, that name isn't great, either) that's fine with me. Also okay with merging as-is.
Continues #296