Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Output thickness, curvature, and sulcal depth files #305

Merged
merged 22 commits into from
Oct 18, 2022

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Oct 14, 2022

Continues #296

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2022

Codecov Report

Base: 70.37% // Head: 68.86% // Decreases project coverage by -1.50% ⚠️

Coverage data is based on head (e5968be) compared to base (ad4401c).
Patch coverage: 52.63% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
- Coverage   70.37%   68.86%   -1.51%     
==========================================
  Files          17       17              
  Lines        1134     1169      +35     
  Branches      189      197       +8     
==========================================
+ Hits          798      805       +7     
- Misses        274      304      +30     
+ Partials       62       60       -2     
Flag Coverage Δ
ds005 59.11% <52.63%> (-1.48%) ⬇️
ds054 49.27% <34.21%> (-1.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
smriprep/utils/bids.py 47.00% <ø> (ø)
smriprep/workflows/anatomical.py 53.59% <ø> (ø)
smriprep/interfaces/freesurfer.py 56.86% <41.93%> (-7.03%) ⬇️
smriprep/workflows/outputs.py 65.80% <100.00%> (+0.44%) ⬆️
smriprep/workflows/surfaces.py 77.31% <100.00%> (+0.72%) ⬆️
smriprep/interfaces/surf.py 70.00% <0.00%> (-8.00%) ⬇️
smriprep/interfaces/reports.py 86.07% <0.00%> (-6.33%) ⬇️
smriprep/cli/run.py 76.99% <0.00%> (-0.47%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mgxd
Copy link
Collaborator Author

mgxd commented Oct 17, 2022

@effigies do you happen to know the BIDS compliant suffixes for sulc/thickness/curv files? I can expand our patterns (https://github.com/nipreps/niworkflows/blob/master/niworkflows/data/nipreps.json) but want to avoid making incompatible outputs from the jump

@effigies
Copy link
Member

@effigies
Copy link
Member

That said, who knows what sorts of arguments will happen before that gets merged.

@mgxd
Copy link
Collaborator Author

mgxd commented Oct 17, 2022

Perfect, staying true to its FS equivalent 😄

Thanks, ready for review

@mgxd mgxd marked this pull request as ready for review October 17, 2022 19:24
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right. Have you run and made sure that the data arrays in the output GIFTIs correspond to the correct FreeSurfer curvature files?

smriprep/workflows/surfaces.py Show resolved Hide resolved
smriprep/workflows/surfaces.py Outdated Show resolved Hide resolved
mgxd and others added 2 commits October 17, 2022 16:15
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@mgxd
Copy link
Collaborator Author

mgxd commented Oct 17, 2022

I have yet to run this on my own data

@mgxd
Copy link
Collaborator Author

mgxd commented Oct 17, 2022

CIFTIs generated by MRIsConvertData match their FS equivalents (loaded with nibabel.freesurfer.io.read_morph_data)

run_without_submitting=True,
)
fscurv2funcgii = pe.MapNode(
MRIsConvertData(out_datatype="gii", to_scanner=True, target_surface="smoothwm"),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lingering question: Should use the ?h.white or ?h.smoothwm surface files?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think to_scanner or target_surface will make any difference here.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgxd If you want to experiment with modifying/removing some args from fscurv2funcgii (and actually, that name isn't great, either) that's fine with me. Also okay with merging as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

None yet

3 participants